@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up some Passphrase transaction bugs
Summary: Ref T12685. Makes the description field full remarkup and fixes setting a credential secret after destruction.
Test Plan: Change description a lot, set and destroy credentials.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T12685
Differential Revision: https://secure.phabricator.com/D17851
+7
-11
+2
-2
src/applications/passphrase/controller/PassphraseCredentialEditController.php
+2
-2
src/applications/passphrase/controller/PassphraseCredentialEditController.php
···
244
244
->setValue($v_name)
245
245
->setError($e_name))
246
246
->appendChild(
247
-
id(new AphrontFormTextAreaControl())
248
-
->setHeight(AphrontFormTextAreaControl::HEIGHT_VERY_SHORT)
247
+
id(new PhabricatorRemarkupControl())
248
+
->setUser($viewer)
249
249
->setName('description')
250
250
->setLabel(pht('Description'))
251
251
->setValue($v_desc))
+5
-9
src/applications/passphrase/xaction/PassphraseCredentialSecretIDTransaction.php
+5
-9
src/applications/passphrase/xaction/PassphraseCredentialSecretIDTransaction.php
···
17
17
$object->setSecretID($value);
18
18
}
19
19
20
-
public function shouldHide() {
21
-
if (!$this->getOldValue()) {
22
-
return true;
23
-
}
24
-
25
-
return false;
26
-
}
27
-
28
20
public function getTitle() {
29
21
$old = $this->getOldValue();
30
-
if ($old === null) {
22
+
if (!$old) {
31
23
return pht(
32
24
'%s attached a new secret to this credential.',
33
25
$this->renderAuthor());
···
51
43
$this->renderAuthor(),
52
44
$this->renderObject());
53
45
}
46
+
}
47
+
48
+
public function getIcon() {
49
+
return 'fa-key';
54
50
}
55
51
56
52
}