@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix invalid return values for void

Summary: Remove or correct wrong @return types in PHPDoc and/or correct wrong return values in methods.

Test Plan: Run static code analysis; read code; check method in parent class and other callers, etc.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25979

+2 -11
+1 -1
src/applications/drydock/worker/DrydockLeaseUpdateWorker.php
··· 169 169 * acquire the lease. 170 170 * 171 171 * @param DrydockLease $lease Requested lease. 172 - * @return void 172 + * @return DrydockResource 173 173 * @task allocator 174 174 */ 175 175 private function executeAllocator(DrydockLease $lease) {
-2
src/applications/metamta/storage/PhabricatorMetaMTAMail.php
··· 531 531 532 532 /** 533 533 * Attempt to deliver an email immediately, in this process. 534 - * 535 - * @return void 536 534 */ 537 535 public function sendNow() { 538 536 if ($this->getStatus() != PhabricatorMailOutboundStatus::STATUS_QUEUE) {
-2
src/applications/people/phid/PhabricatorPeopleUserEmailPHIDType.php
··· 34 34 $email = $objects[$phid]; 35 35 $handle->setName($email->getAddress()); 36 36 } 37 - 38 - return null; 39 37 } 40 38 41 39 }
-1
src/applications/search/query/PhabricatorSearchDocumentQuery.php
··· 105 105 protected function nextPage(array $page) { 106 106 // We already updated the internal offset in `loadPage()` after loading 107 107 // results, so we do not need to make any additional state updates here. 108 - return $this; 109 108 } 110 109 111 110 }
-2
src/infrastructure/customfield/field/PhabricatorCustomField.php
··· 794 794 * query. 795 795 * @param PhabricatorCursorPagedPolicyAwareQuery $query Query to constrain. 796 796 * @param wild $value Constraint provided by the user. 797 - * @return void 798 797 * @task appsearch 799 798 */ 800 799 public function applyApplicationSearchConstraintToQuery( ··· 818 817 * form. 819 818 * @param AphrontFormView $form The form to update. 820 819 * @param wild $value Value from the saved query. 821 - * @return void 822 820 * @task appsearch 823 821 */ 824 822 public function appendToApplicationSearchForm(
+1 -1
src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
··· 48 48 * 49 49 * @param PhabricatorCustomFieldInterface $object Object to read field values 50 50 * for. 51 - * @return void 51 + * @return $this 52 52 */ 53 53 public function readFieldsFromStorage( 54 54 PhabricatorCustomFieldInterface $object) {
-1
src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php
··· 74 74 // (Before T13266, we raised an exception here, but since "nextPage()" is 75 75 // now called even if we don't page we can't do that anymore. Just do 76 76 // nothing instead.) 77 - return null; 78 77 } 79 78 80 79 protected function loadPage() {
-1
src/infrastructure/daemon/workers/storage/PhabricatorWorkerTrigger.php
··· 86 86 * is the first execution. 87 87 * @param int $this_event Scheduled epoch of this execution. This may not be 88 88 * the same as the current time. 89 - * @return void 90 89 */ 91 90 public function executeTrigger($last_event, $this_event) { 92 91 return $this->getAction()->execute($last_event, $this_event);