@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Underp ReleephDefaultFieldSelector
Summary: Oops. Functions only return stuff when you call the `return()` function on the `lvalue`.
Test Plan: Use `ReleephDefaultFieldSelector` is the field selector in a test Releeph project.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D5362
+2
-2
+2
-2
src/applications/releeph/field/selector/ReleephDefaultFieldSelector.php
+2
-2
src/applications/releeph/field/selector/ReleephDefaultFieldSelector.php
···
54
54
}
55
55
56
56
public function arrangeFieldsForSelectForm(array $fields) {
57
-
self::selectFields($fields, array(
57
+
return self::selectFields($fields, array(
58
58
'ReleephStatusFieldSpecification',
59
59
'ReleephSeverityFieldSpecification',
60
60
'ReleephRequestorFieldSpecification',
···
62
62
}
63
63
64
64
public function sortFieldsForCommitMessage(array $fields) {
65
-
self::selectFields($fields, array(
65
+
return self::selectFields($fields, array(
66
66
'ReleephCommitMessageFieldSpecification',
67
67
'ReleephRequestorFieldSpecification',
68
68
'ReleephIntentFieldSpecification',