@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix some minor errors (DarkConsole warning, unstable Ferret sort)
Summary:
DarkConsole could warn when "Analyze Query Plans" was not active.
`msort()` is not stable, so Ferret results with similar relevance could be returned out-of-order.
Test Plan: Saw fewer traces and more-stable result ordering.
Differential Revision: https://secure.phabricator.com/D19236
+2
-2
+1
-1
src/applications/console/plugin/DarkConsoleServicesPlugin.php
+1
-1
src/applications/console/plugin/DarkConsoleServicesPlugin.php
+1
-1
src/applications/search/fulltextstorage/PhabricatorFerretFulltextStorageEngine.php
+1
-1
src/applications/search/fulltextstorage/PhabricatorFerretFulltextStorageEngine.php
···
104
104
// Reorder the results so that the highest-ranking results come first,
105
105
// no matter which object types they belong to.
106
106
107
-
$metadata = msort($metadata, 'getRelevanceSortVector');
107
+
$metadata = msortv($metadata, 'getRelevanceSortVector');
108
108
$list = array_select_keys($list, array_keys($metadata)) + $list;
109
109
110
110
$result_slice = array_slice($list, $offset, $limit, true);