@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fill in some straightforward Maniphest transactions for `transaction.search`
Summary:
See PHI197. Populates "status" transactions and a few other obvious types where there's no security/performance/payload/formatting issue I can come up with.
The names here are the same as the names for editing with `maniphest.edit`.
Test Plan: Used `transaction.search` to retrieve transactions of all new types.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D18761
+57
-3
+3
-3
src/applications/differential/xaction/DifferentialRevisionStatusTransaction.php
+3
-3
src/applications/differential/xaction/DifferentialRevisionStatusTransaction.php
···
74
74
return 'status';
75
75
}
76
76
77
-
public function getFieldValuesForConduit($object, $data) {
77
+
public function getFieldValuesForConduit($xaction, $data) {
78
78
return array(
79
-
'old' => $object->getOldValue(),
80
-
'new' => $object->getNewValue(),
79
+
'old' => $xaction->getOldValue(),
80
+
'new' => $xaction->getNewValue(),
81
81
);
82
82
}
83
83
+10
src/applications/maniphest/xaction/ManiphestTaskDescriptionTransaction.php
+10
src/applications/maniphest/xaction/ManiphestTaskDescriptionTransaction.php
···
57
57
return $changes;
58
58
}
59
59
60
+
public function getTransactionTypeForConduit($xaction) {
61
+
return 'description';
62
+
}
63
+
64
+
public function getFieldValuesForConduit($xaction, $data) {
65
+
return array(
66
+
'old' => $xaction->getOldValue(),
67
+
'new' => $xaction->getNewValue(),
68
+
);
69
+
}
60
70
61
71
}
+10
src/applications/maniphest/xaction/ManiphestTaskOwnerTransaction.php
+10
src/applications/maniphest/xaction/ManiphestTaskOwnerTransaction.php
···
154
154
155
155
}
156
156
157
+
public function getTransactionTypeForConduit($xaction) {
158
+
return 'owner';
159
+
}
160
+
161
+
public function getFieldValuesForConduit($xaction, $data) {
162
+
return array(
163
+
'old' => $xaction->getOldValue(),
164
+
'new' => $xaction->getNewValue(),
165
+
);
166
+
}
157
167
158
168
}
+12
src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php
+12
src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php
···
107
107
return $value;
108
108
}
109
109
110
+
public function getTransactionTypeForConduit($xaction) {
111
+
return 'points';
112
+
}
113
+
114
+
public function getFieldValuesForConduit($xaction, $data) {
115
+
return array(
116
+
'old' => $xaction->getOldValue(),
117
+
'new' => $xaction->getNewValue(),
118
+
);
119
+
}
120
+
121
+
110
122
}
+11
src/applications/maniphest/xaction/ManiphestTaskStatusTransaction.php
+11
src/applications/maniphest/xaction/ManiphestTaskStatusTransaction.php
···
229
229
230
230
}
231
231
232
+
public function getTransactionTypeForConduit($xaction) {
233
+
return 'status';
234
+
}
235
+
236
+
public function getFieldValuesForConduit($xaction, $data) {
237
+
return array(
238
+
'old' => $xaction->getOldValue(),
239
+
'new' => $xaction->getNewValue(),
240
+
);
241
+
}
242
+
232
243
}
+11
src/applications/maniphest/xaction/ManiphestTaskTitleTransaction.php
+11
src/applications/maniphest/xaction/ManiphestTaskTitleTransaction.php
···
72
72
return $errors;
73
73
}
74
74
75
+
public function getTransactionTypeForConduit($xaction) {
76
+
return 'title';
77
+
}
78
+
79
+
public function getFieldValuesForConduit($xaction, $data) {
80
+
return array(
81
+
'old' => $xaction->getOldValue(),
82
+
'new' => $xaction->getNewValue(),
83
+
);
84
+
}
85
+
75
86
}