@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Swap transactions and initialization over to modern status constants
Summary: Ref T2543. Update these for the modern stuff.
Test Plan: Created a new revision, got a revision in the right state ("Needs Review"). Accepted, planned, requested, abandoned revision; state transitions looked good.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T2543
Differential Revision: https://secure.phabricator.com/D18415
+13
-10
+1
-1
src/applications/differential/storage/DifferentialRevision.php
+1
-1
src/applications/differential/storage/DifferentialRevision.php
···
72
72
->attachRepository(null)
73
73
->attachActiveDiff(null)
74
74
->attachReviewers(array())
75
-
->setStatus(ArcanistDifferentialRevisionStatus::NEEDS_REVIEW);
75
+
->setModernRevisionStatus(DifferentialRevisionStatus::NEEDS_REVIEW);
76
76
}
77
77
78
78
protected function getConfiguration() {
+2
-1
src/applications/differential/xaction/DifferentialRevisionAbandonTransaction.php
+2
-1
src/applications/differential/xaction/DifferentialRevisionAbandonTransaction.php
···
47
47
}
48
48
49
49
public function applyInternalEffects($object, $value) {
50
-
$object->setStatus(ArcanistDifferentialRevisionStatus::ABANDONED);
50
+
$status_abandoned = DifferentialRevisionStatus::ABANDONED;
51
+
$object->setModernRevisionStatus($status_abandoned);
51
52
}
52
53
53
54
protected function validateAction($object, PhabricatorUser $viewer) {
+2
-2
src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
+2
-2
src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
···
37
37
public function applyInternalEffects($object, $value) {
38
38
$was_accepted = $object->isAccepted();
39
39
40
-
$status_closed = ArcanistDifferentialRevisionStatus::CLOSED;
41
-
$object->setStatus($status_closed);
40
+
$status_published = DifferentialRevisionStatus::PUBLISHED;
41
+
$object->setModernRevisionStatus($status_published);
42
42
43
43
$object->setProperty(
44
44
DifferentialRevision::PROPERTY_CLOSED_FROM_ACCEPTED,
+2
-2
src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php
+2
-2
src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php
···
50
50
}
51
51
52
52
public function applyInternalEffects($object, $value) {
53
-
$status_planned = ArcanistDifferentialRevisionStatus::CHANGES_PLANNED;
54
-
$object->setStatus($status_planned);
53
+
$status_planned = DifferentialRevisionStatus::CHANGES_PLANNED;
54
+
$object->setModernRevisionStatus($status_planned);
55
55
}
56
56
57
57
protected function validateAction($object, PhabricatorUser $viewer) {
+2
-1
src/applications/differential/xaction/DifferentialRevisionReclaimTransaction.php
+2
-1
src/applications/differential/xaction/DifferentialRevisionReclaimTransaction.php
···
47
47
}
48
48
49
49
public function applyInternalEffects($object, $value) {
50
-
$object->setStatus(ArcanistDifferentialRevisionStatus::NEEDS_REVIEW);
50
+
$status_review = DifferentialRevisionStatus::NEEDS_REVIEW;
51
+
$object->setModernRevisionStatus($status_review);
51
52
}
52
53
53
54
protected function validateAction($object, PhabricatorUser $viewer) {
+2
-1
src/applications/differential/xaction/DifferentialRevisionReopenTransaction.php
+2
-1
src/applications/differential/xaction/DifferentialRevisionReopenTransaction.php
···
35
35
}
36
36
37
37
public function applyInternalEffects($object, $value) {
38
-
$object->setStatus(ArcanistDifferentialRevisionStatus::NEEDS_REVIEW);
38
+
$status_review = DifferentialRevisionStatus::NEEDS_REVIEW;
39
+
$object->setModernRevisionStatus($status_review);
39
40
}
40
41
41
42
protected function validateAction($object, PhabricatorUser $viewer) {
+2
-2
src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php
+2
-2
src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php
···
31
31
}
32
32
33
33
public function applyInternalEffects($object, $value) {
34
-
$status_review = ArcanistDifferentialRevisionStatus::NEEDS_REVIEW;
35
-
$object->setStatus($status_review);
34
+
$status_review = DifferentialRevisionStatus::NEEDS_REVIEW;
35
+
$object->setModernRevisionStatus($status_review);
36
36
}
37
37
38
38
protected function validateAction($object, PhabricatorUser $viewer) {