@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Revising Flag UI
Summary:
Re-adding side nav (feels less spacy now).
Replaced header with crumb. Looks nicer with the filter imo.
Test Plan: {F38201}
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D5517
authored by
Anh Nhan Nguyen
and committed by
epriestley
cdcd49e4
6e197fe9
+11
-5
+11
-5
src/applications/flag/controller/PhabricatorFlagListController.php
+11
-5
src/applications/flag/controller/PhabricatorFlagListController.php
···
7
7
$user = $request->getUser();
8
8
9
9
$nav = new AphrontSideNavFilterView();
10
+
$nav->setBaseURI(new PhutilURI('/flag/view/'));
11
+
$nav->addLabel(pht('Flags'));
12
+
$nav->addFilter('all', pht('Your Flags'));
13
+
$nav->selectFilter('all', 'all');
14
+
15
+
$crumbs = $this->buildApplicationCrumbs();
16
+
$crumbs->addCrumb(id(new PhabricatorCrumbView)
17
+
->setName(pht('Flags'))
18
+
->setHref($request->getRequestURI()));
19
+
$nav->setCrumbs($crumbs);
10
20
11
21
$filter_form = new AphrontFormView();
12
22
$filter_form->setUser($user);
···
26
36
27
37
$filter = new AphrontListFilterView();
28
38
$filter->appendChild($filter_form);
39
+
$nav->appendChild($filter);
29
40
30
41
$query = new PhabricatorFlagQuery();
31
42
$query->withOwnerPHIDs(array($user->getPHID()));
···
56
67
$view->setFlags($flags);
57
68
$view->setUser($user);
58
69
59
-
$header = new PhabricatorHeaderView();
60
-
$header->setHeader(pht('Flags'));
61
-
62
-
$nav->appendChild($header);
63
-
$nav->appendChild($filter);
64
70
$nav->appendChild($view);
65
71
66
72
return $this->buildApplicationPage(