@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix missing `willUpload` hook for drag-and-drop chunked upload

Summary:
Ref T9324. When you upload a normal file, we call `willUpload` and then `didUpload`.

When you upload a chunked file, we never call `willUpload`. This can get things out of sync. Make sure we invoke this event for both chunked and non-chunked uploads.

Test Plan: Got cleaner behavior (redirect after all uploads finish) in new Phacility file upload area.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9324

Differential Revision: https://secure.phabricator.com/D14083

+13 -11
+11 -11
resources/celerity/map.php
··· 11 11 'core.pkg.js' => '47dc9ebb', 12 12 'darkconsole.pkg.js' => 'e7393ebb', 13 13 'differential.pkg.css' => '2de124c9', 14 - 'differential.pkg.js' => '813c1633', 14 + 'differential.pkg.js' => '52d725be', 15 15 'diffusion.pkg.css' => '385e85b3', 16 16 'diffusion.pkg.js' => '0115b37c', 17 17 'maniphest.pkg.css' => '4845691a', ··· 429 429 'rsrc/js/application/uiexample/gesture-example.js' => '558829c2', 430 430 'rsrc/js/application/uiexample/notification-example.js' => '8ce821c5', 431 431 'rsrc/js/core/Busy.js' => '59a7976a', 432 - 'rsrc/js/core/DragAndDropFileUpload.js' => '07de8873', 432 + 'rsrc/js/core/DragAndDropFileUpload.js' => 'ad10aeac', 433 433 'rsrc/js/core/DraggableList.js' => 'a16ec1c6', 434 434 'rsrc/js/core/FileUpload.js' => '477359c8', 435 435 'rsrc/js/core/Hovercard.js' => '14ac66f5', ··· 718 718 'phabricator-core-css' => 'a76cefc9', 719 719 'phabricator-countdown-css' => 'e7544472', 720 720 'phabricator-dashboard-css' => 'eb458607', 721 - 'phabricator-drag-and-drop-file-upload' => '07de8873', 721 + 'phabricator-drag-and-drop-file-upload' => 'ad10aeac', 722 722 'phabricator-draggable-list' => 'a16ec1c6', 723 723 'phabricator-fatal-config-template-css' => '8e6c6fcd', 724 724 'phabricator-feed-css' => 'ecd4ec57', ··· 885 885 'javelin-stratcom', 886 886 'javelin-workflow', 887 887 ), 888 - '07de8873' => array( 889 - 'javelin-install', 890 - 'javelin-util', 891 - 'javelin-request', 892 - 'javelin-dom', 893 - 'javelin-uri', 894 - 'phabricator-file-upload', 895 - ), 896 888 '087e919c' => array( 897 889 'javelin-install', 898 890 'javelin-dom', ··· 1657 1649 'javelin-util', 1658 1650 'javelin-stratcom', 1659 1651 'javelin-install', 1652 + ), 1653 + 'ad10aeac' => array( 1654 + 'javelin-install', 1655 + 'javelin-util', 1656 + 'javelin-request', 1657 + 'javelin-dom', 1658 + 'javelin-uri', 1659 + 'phabricator-file-upload', 1660 1660 ), 1661 1661 'b064af76' => array( 1662 1662 'javelin-behavior',
+2
webroot/rsrc/js/core/DragAndDropFileUpload.js
··· 230 230 .setStatus('allocate') 231 231 .update(); 232 232 233 + this.invoke('willUpload', file); 234 + 233 235 var alloc_uri = this._getUploadURI(file) 234 236 .setQueryParam('allocate', 1); 235 237