@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Removing deprecated method calls
Summary: Removed call to the deprecated buildStandardPageResponse method from XHProfProfileController
Test Plan: Install, configure, and use XHProf. I'll need some guidance with this
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D16432
+11
-29
-22
src/applications/xhprof/controller/PhabricatorXHProfController.php
-22
src/applications/xhprof/controller/PhabricatorXHProfController.php
···
2
2
3
3
abstract class PhabricatorXHProfController extends PhabricatorController {
4
4
5
-
public function buildStandardPageResponse($view, array $data) {
6
-
$page = $this->buildStandardPageView();
7
-
8
-
$page->setApplicationName(pht('XHProf'));
9
-
$page->setBaseURI('/xhprof/');
10
-
$page->setTitle(idx($data, 'title'));
11
-
$page->setGlyph("\xE2\x98\x84");
12
-
$page->appendChild($view);
13
-
$page->setDeviceReady(true);
14
-
15
-
$response = new AphrontWebpageResponse();
16
-
17
-
if (isset($data['frame'])) {
18
-
$response->setFrameable(true);
19
-
$page->setFrameable(true);
20
-
$page->setShowChrome(false);
21
-
$page->setDisableConsole(true);
22
-
}
23
-
24
-
return $response->setContent($page->render());
25
-
}
26
-
27
5
}
+9
-6
src/applications/xhprof/controller/PhabricatorXHProfProfileController.php
+9
-6
src/applications/xhprof/controller/PhabricatorXHProfProfileController.php
···
47
47
$crumbs = $this->buildApplicationCrumbs();
48
48
$crumbs->addTextCrumb(pht('%s Profile', $symbol));
49
49
50
-
return $this->buildStandardPageResponse(
51
-
array($crumbs, $view),
52
-
array(
53
-
'title' => pht('Profile'),
54
-
'frame' => $is_framed,
55
-
));
50
+
$title = pht('Profile');
51
+
52
+
return $this->newPage()
53
+
->setTitle($title)
54
+
->setCrumbs($crumbs)
55
+
->setFrameable(true)
56
+
->setShowChrome(false)
57
+
->setDisableConsole(true)
58
+
->appendChild($view);
56
59
}
57
60
}
+2
-1
src/view/page/PhabricatorStandardPageView.php
+2
-1
src/view/page/PhabricatorStandardPageView.php