recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix call to non-existing getTransactionCommentForSave() in PhabricatorInlineComment

Summary:
rPb48a22bf50a32895566e9aa66c1d7aff87a492b8 moved the call `$this->getTransactionCommentForSave()->save()` from within `PhabricatorAuditInlineComment` to the new (parent) class `PhabricatorInlineComment.php`, however the later does not define this function.

As the two child classes which extend `PhabricatorInlineComment` both implement `getTransactionCommentForSave()`, declare an abstract function in their parent class.

Test Plan: Carefully read the code.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25644

Andre Klapper d2bca2f3 17b568b9

+5
+5
src/infrastructure/diff/interface/PhabricatorInlineComment.php
··· 101 101 abstract public function supportsHiding(); 102 102 abstract public function isHidden(); 103 103 104 + /** 105 + * @return Phobject 106 + */ 107 + abstract public function getTransactionCommentForSave(); 108 + 104 109 public function isDraft() { 105 110 return !$this->getTransactionPHID(); 106 111 }