recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

a11y: Add aria-label to calendar date picker button

Summary:
Form elements should have associated labels per https://www.w3.org/WAI/tutorials/forms/labels/

Ref T16072

Test Plan:
Have a custom field of `"type": "date"` defined in `/config/edit/maniphest.custom-field-definitions/`.
Go to edit a task (`/maniphest/task/edit/1/`) whose form exposes that custom field.
Inspect the `<a>` field parameters with `class="calendar-button"` and see an additional `aria-label="Calendar date picker"`.
Optionally, run an Accessibility check in Chromium Lighthouse.

Reviewers: O1 Blessed Committers, chris

Reviewed By: O1 Blessed Committers, chris

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16072

Differential Revision: https://we.phorge.it/D26046

Andre Klapper d534ca7b 0c65f2d3

+4 -3
+4 -3
src/view/form/control/AphrontFormDateControl.php
··· 227 227 $cal_icon = javelin_tag( 228 228 'a', 229 229 array( 230 - 'href' => '#', 231 - 'class' => 'calendar-button', 232 - 'sigil' => 'calendar-button', 230 + 'href' => '#', 231 + 'class' => 'calendar-button', 232 + 'sigil' => 'calendar-button', 233 + 'aria-label' => pht('Calendar date picker'), 233 234 ), 234 235 $cicon); 235 236