-18

src/applications/conpherence/__tests__/ConpherenceRoomTestCase.php

reviewed

··· 124 124 return $conpherence; 125 125 } 126 126 127 127 - private function changeEditPolicy( 128 128 - PhabricatorUser $actor, 129 129 - ConpherenceThread $room, 130 130 - $policy) { 131 131 - 132 132 - $xactions = array(); 133 133 - $xactions[] = id(new ConpherenceTransaction()) 134 134 - ->setTransactionType(PhabricatorTransactions::TYPE_EDIT_POLICY) 135 135 - ->setNewValue($policy); 136 136 - 137 137 - id(new ConpherenceEditor()) 138 138 - ->setActor($actor) 139 139 - ->setContentSource($this->newContentSource()) 140 140 - ->setContinueOnNoEffect(true) 141 141 - ->applyTransactions($room, $xactions); 142 142 - } 143 143 - 144 144 - 145 127 }

-14

src/applications/conpherence/view/ConpherenceThreadListView.php

reviewed

··· 155 155 return $item; 156 156 } 157 157 158 158 - private function getNoRoomsMenuItem() { 159 159 - $message = phutil_tag( 160 160 - 'div', 161 161 - array( 162 162 - 'class' => 'no-conpherences-menu-item', 163 163 - ), 164 164 - pht('No Rooms')); 165 165 - 166 166 - return id(new PHUIListItemView()) 167 167 - ->setType(PHUIListItemView::TYPE_CUSTOM) 168 168 - ->setName($message); 169 169 - } 170 170 - 171 171 - 172 158 }

-29

src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php

reviewed

··· 562 562 ); 563 563 } 564 564 565 565 - private function selectDaemonPIDs(array $daemons, array $pids) { 566 566 - $console = PhutilConsole::getConsole(); 567 567 - 568 568 - $running_pids = array_fuse(mpull($daemons, 'getPID')); 569 569 - if (!$pids) { 570 570 - $select_pids = $running_pids; 571 571 - } else { 572 572 - // We were given a PID or set of PIDs to kill. 573 573 - $select_pids = array(); 574 574 - foreach ($pids as $key => $pid) { 575 575 - if (!preg_match('/^\d+$/', $pid)) { 576 576 - $console->writeErr(pht("PID '%s' is not a valid PID.", $pid)."\n"); 577 577 - continue; 578 578 - } else if (empty($running_pids[$pid])) { 579 579 - $console->writeErr( 580 580 - "%s\n", 581 581 - pht( 582 582 - 'PID "%d" is not a known daemon PID.', 583 583 - $pid)); 584 584 - continue; 585 585 - } else { 586 586 - $select_pids[$pid] = $pid; 587 587 - } 588 588 - } 589 589 - } 590 590 - 591 591 - return $select_pids; 592 592 - } 593 593 - 594 565 protected function getOverseerProcessRefs() { 595 566 $query = id(new PhutilProcessQuery()) 596 567 ->withIsOverseer(true);

-5

src/applications/differential/editor/DifferentialTransactionEditor.php

reviewed

··· 1384 1384 return implode("\n", $filenames); 1385 1385 } 1386 1386 1387 1387 - private function renderPatchHTMLForMail($patch) { 1388 1388 - return phutil_tag('pre', 1389 1389 - array('style' => 'font-family: monospace;'), $patch); 1390 1390 - } 1391 1391 - 1392 1387 private function buildPatchForMail(DifferentialDiff $diff, $byte_limit) { 1393 1388 $format = PhabricatorEnv::getEnvConfig('metamta.differential.patch-format'); 1394 1389

-12

src/applications/differential/query/DifferentialRevisionSearchEngine.php

reviewed

··· 172 172 return parent::buildSavedQueryFromBuiltin($query_key); 173 173 } 174 174 175 175 - private function getStatusOptions() { 176 176 - return array( 177 177 - DifferentialLegacyQuery::STATUS_ANY => pht('All'), 178 178 - DifferentialLegacyQuery::STATUS_OPEN => pht('Open'), 179 179 - DifferentialLegacyQuery::STATUS_ACCEPTED => pht('Accepted'), 180 180 - DifferentialLegacyQuery::STATUS_NEEDS_REVIEW => pht('Needs Review'), 181 181 - DifferentialLegacyQuery::STATUS_NEEDS_REVISION => pht('Needs Revision'), 182 182 - DifferentialLegacyQuery::STATUS_CLOSED => pht('Closed'), 183 183 - DifferentialLegacyQuery::STATUS_ABANDONED => pht('Abandoned'), 184 184 - ); 185 185 - } 186 186 - 187 175 protected function renderResultList( 188 176 array $revisions, 189 177 PhabricatorSavedQuery $query,

-7

src/applications/differential/xaction/DifferentialRevisionVoidTransaction.php

reviewed

··· 82 82 return true; 83 83 } 84 84 85 85 - private function getVoidableStatuses() { 86 86 - return array( 87 87 - DifferentialReviewerStatus::STATUS_ACCEPTED, 88 88 - DifferentialReviewerStatus::STATUS_REJECTED, 89 89 - ); 90 90 - } 91 91 - 92 85 }

-4

src/applications/diffusion/doorkeeper/DiffusionDoorkeeperCommitFeedStoryPublisher.php

reviewed

··· 7 7 private $activePHIDs; 8 8 private $passivePHIDs; 9 9 10 10 - private function getAuditRequests() { 11 11 - return $this->auditRequests; 12 12 - } 13 13 - 14 10 public function canPublishStory(PhabricatorFeedStory $story, $object) { 15 11 return 16 12 ($story instanceof PhabricatorApplicationTransactionFeedStory) &&

-4

src/view/phui/PHUIPagerView.php

reviewed

··· 76 76 + ($this->hasMorePages ? 1 : 0); 77 77 } 78 78 79 79 - private function isExactCountKnown() { 80 80 - return $this->count !== null; 81 81 - } 82 82 - 83 79 /** 84 80 * A common paging strategy is to select one extra record and use that to 85 81 * indicate that there's an additional page (this doesn't give you a

-18

src/view/phui/calendar/PHUICalendarDayView.php

reviewed

··· 296 296 return $header; 297 297 } 298 298 299 299 - private function updateEventsFromCluster($cluster, $hourly_events) { 300 300 - $cluster_size = count($cluster); 301 301 - $n = 0; 302 302 - foreach ($cluster as $cluster_member) { 303 303 - $event_id = $cluster_member->getEventID(); 304 304 - $offset = (($n / $cluster_size) * 100).'%'; 305 305 - $width = ((1 / $cluster_size) * 100).'%'; 306 306 - 307 307 - if (isset($hourly_events[$event_id])) { 308 308 - $hourly_events[$event_id]['offset'] = $offset; 309 309 - $hourly_events[$event_id]['width'] = $width; 310 310 - } 311 311 - $n++; 312 312 - } 313 313 - 314 314 - return $hourly_events; 315 315 - } 316 316 - 317 299 // returns DateTime of each hour in the day 318 300 private function getHoursOfDay() { 319 301 $included_datetimes = array();