@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Never hide file contents if they have comments.
Summary:
Links to comments were not working because file was hidden after it was deleted.
Test Plan:
Tested that comment anchors were working correctly for deleted files.
Tested that generated files were still hidden.
Reviewed By: epriestley
Reviewers: epriestley
CC: jungejason, aran, epriestley
Differential Revision: 257
+1
-1
+1
-1
src/applications/differential/parser/changeset/DifferentialChangesetParser.php
+1
-1
src/applications/differential/parser/changeset/DifferentialChangesetParser.php
···
816
816
}
817
817
818
818
$shield = null;
819
-
if ($range_start === null && $range_len === null) {
819
+
if ($range_start === null && $range_len === null && !$this->comments) {
820
820
if ($this->isGenerated()) {
821
821
$shield = $this->renderShield(
822
822
"This file contains generated code, which does not normally need ".