@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add square brackets around new revision review requests
Summary:
These didn't get covered when we added square brackets to the rest of the emails
(so gmail can thread them properly).
Test Plan:
Created a local diff, got an email with brackets.
Reviewed By: tuomaspelkonen
Reviewers: rm, tuomaspelkonen, jungejason, aran
CC: aran, epriestley, tuomaspelkonen
Differential Revision: 256
+4
-1
+4
-1
src/applications/differential/mail/newdiff/DifferentialNewDiffMail.php
+4
-1
src/applications/differential/mail/newdiff/DifferentialNewDiffMail.php
···
29
29
$verb = 'Updated';
30
30
}
31
31
32
-
return "{$verb} ({$lines}): ".$revision->getTitle();
32
+
$revision_id = $revision->getID();
33
+
$revision_title = $revision->getTitle();
34
+
35
+
return "[{$verb}, {$lines}] D{$revision_id}: {$revision_title}";
33
36
}
34
37
35
38
protected function buildSubject() {