@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Minor, make sure we release locks in pull daemon if we fail in unusual ways
Summary: A user is reporting a re-lock in this daemon, which I can't
reproduce, but might be possible if this throws. Stop it from throwing in
a way which evades unlock.
See: <https://github.com/facebook/phabricator/issues/476>
Auditors: btrahan
+3
-4
+3
-4
src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php
+3
-4
src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php
···
144
144
$lock = PhabricatorGlobalLock::newLock($lock_name);
145
145
$lock->lock();
146
146
147
-
$repository->writeStatusMessage(
148
-
PhabricatorRepositoryStatusMessage::TYPE_NEEDS_UPDATE,
149
-
null);
150
-
151
147
try {
148
+
$repository->writeStatusMessage(
149
+
PhabricatorRepositoryStatusMessage::TYPE_NEEDS_UPDATE,
150
+
null);
152
151
$this->discoverRepository($repository);
153
152
$repository->writeStatusMessage(
154
153
PhabricatorRepositoryStatusMessage::TYPE_FETCH,