@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update Herald for PHUITwoColumnView
Summary: Updates Herald to new two column layout
Test Plan: View herald rule tablet, desktop, mobile
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D15373
authored by
Chad Little
and committed by
chad
db4fdf8c
21f83236
+31
-11
+31
-11
src/applications/herald/controller/HeraldRuleViewController.php
+31
-11
src/applications/herald/controller/HeraldRuleViewController.php
···
33
33
}
34
34
35
35
$actions = $this->buildActionView($rule);
36
-
$properties = $this->buildPropertyView($rule, $actions);
36
+
$properties = $this->buildPropertyView($rule);
37
+
$details = $this->buildDetailsView($rule);
37
38
38
39
$id = $rule->getID();
39
40
40
41
$crumbs = $this->buildApplicationCrumbs();
41
42
$crumbs->addTextCrumb("H{$id}");
43
+
$crumbs->setBorder(true);
42
44
43
45
$object_box = id(new PHUIObjectBoxView())
44
46
->setHeader($header)
···
51
53
52
54
$title = $rule->getName();
53
55
56
+
$view = id(new PHUITwoColumnView())
57
+
->setHeader($header)
58
+
->setMainColumn(array(
59
+
$details,
60
+
$timeline,
61
+
))
62
+
->setPropertyList($properties)
63
+
->setActionList($actions);
64
+
54
65
return $this->newPage()
55
66
->setTitle($title)
56
67
->setCrumbs($crumbs)
57
68
->appendChild(
58
69
array(
59
-
$object_box,
60
-
$timeline,
70
+
$view,
61
71
));
62
72
}
63
73
···
105
115
}
106
116
107
117
private function buildPropertyView(
108
-
HeraldRule $rule,
109
-
PhabricatorActionListView $actions) {
118
+
HeraldRule $rule) {
110
119
111
120
$viewer = $this->getRequest()->getUser();
112
-
113
121
$view = id(new PHUIPropertyListView())
114
122
->setUser($viewer)
115
-
->setObject($rule)
116
-
->setActionList($actions);
123
+
->setObject($rule);
124
+
125
+
$view->invokeWillRenderEvent();
126
+
127
+
return $view;
128
+
}
129
+
130
+
private function buildDetailsView(
131
+
HeraldRule $rule) {
132
+
133
+
$viewer = $this->getRequest()->getUser();
134
+
$view = id(new PHUIPropertyListView())
135
+
->setUser($viewer);
117
136
118
137
$view->addProperty(
119
138
pht('Rule Type'),
···
139
158
$viewer->renderHandle($rule->getTriggerObjectPHID()));
140
159
}
141
160
142
-
$view->invokeWillRenderEvent();
143
-
144
161
$view->addSectionHeader(
145
162
pht('Rule Description'),
146
163
PHUIPropertyListView::ICON_SUMMARY);
···
150
167
$view->addTextContent($rule_text);
151
168
}
152
169
153
-
return $view;
170
+
return id(new PHUIObjectBoxView())
171
+
->setHeaderText(pht('DETAILS'))
172
+
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
173
+
->appendChild($view);
154
174
}
155
175
156
176
}