@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make "Quote" work with EditEngine in Paste and Maniphest
Summary: Ref T9132. This makes the "Quote" action on comments work properly in these applications.
Test Plan: Quoted text in each application.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9132
Differential Revision: https://secure.phabricator.com/D14665
+18
-3
+3
src/applications/maniphest/controller/ManiphestTaskDetailController.php
+3
src/applications/maniphest/controller/ManiphestTaskDetailController.php
-1
src/applications/maniphest/editor/ManiphestEditEngine.php
-1
src/applications/maniphest/editor/ManiphestEditEngine.php
···
73
73
// - Don't show "change status" for closed tasks.
74
74
// - Don't show "change owner" for closed tasks.
75
75
// - Don't let users change a task status to "Duplicate".
76
-
// - Make sure "Quote" works.
77
76
// - When closing an unassigned task, assign the closing user.
78
77
// - Make sure implicit CCs on actions are working reasonably.
79
78
+5
-1
src/applications/paste/controller/PhabricatorPasteViewController.php
+5
-1
src/applications/paste/controller/PhabricatorPasteViewController.php
···
64
64
),
65
65
$source_code);
66
66
67
+
$monogram = $paste->getMonogram();
67
68
$crumbs = $this->buildApplicationCrumbs()
68
-
->addTextCrumb('P'.$paste->getID(), '/P'.$paste->getID());
69
+
->addTextCrumb($monogram, '/'.$monogram);
69
70
70
71
$timeline = $this->buildTransactionTimeline(
71
72
$paste,
···
74
75
$comment_view = id(new PhabricatorPasteEditEngine())
75
76
->setViewer($viewer)
76
77
->buildEditEngineCommentView($paste);
78
+
79
+
$timeline->setQuoteRef($monogram);
80
+
$comment_view->setTransactionTimeline($timeline);
77
81
78
82
return $this->newPage()
79
83
->setTitle($paste->getFullName())
+10
-1
src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
+10
-1
src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
···
23
23
private $currentVersion;
24
24
private $versionedDraft;
25
25
private $editTypes;
26
+
private $transactionTimeline;
26
27
27
28
public function setObjectPHID($object_phid) {
28
29
$this->objectPHID = $object_phid;
···
110
111
return $this->editTypes;
111
112
}
112
113
113
-
public function render() {
114
+
public function setTransactionTimeline(
115
+
PhabricatorApplicationTransactionView $timeline) {
116
+
117
+
$timeline->setQuoteTargetID($this->getCommentID());
114
118
119
+
$this->transactionTimeline = $timeline;
120
+
return $this;
121
+
}
122
+
123
+
public function render() {
115
124
$user = $this->getUser();
116
125
if (!$user->isLoggedIn()) {
117
126
$uri = id(new PhutilURI('/login/'))