@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove "Name Contains" query constraint from Diffusion for Repositories
Summary:
Ref T12819. Obsoleted by the Ferret engine "Query" field.
This is a compatibility break, I'll note it in the changelog.
Test Plan: Searched for repositories by name with "Query" instead of "Name Contains".
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T12819
Differential Revision: https://secure.phabricator.com/D18588
-20
-13
src/applications/repository/query/PhabricatorRepositoryQuery.php
-13
src/applications/repository/query/PhabricatorRepositoryQuery.php
···
8
8
private $callsigns;
9
9
private $types;
10
10
private $uuids;
11
-
private $nameContains;
12
11
private $uris;
13
12
private $datasourceQuery;
14
13
private $slugs;
···
113
112
114
113
public function withUUIDs(array $uuids) {
115
114
$this->uuids = $uuids;
116
-
return $this;
117
-
}
118
-
119
-
public function withNameContains($contains) {
120
-
$this->nameContains = $contains;
121
115
return $this;
122
116
}
123
117
···
659
653
$conn,
660
654
'r.uuid IN (%Ls)',
661
655
$this->uuids);
662
-
}
663
-
664
-
if (strlen($this->nameContains)) {
665
-
$where[] = qsprintf(
666
-
$conn,
667
-
'r.name LIKE %~',
668
-
$this->nameContains);
669
656
}
670
657
671
658
if (strlen($this->datasourceQuery)) {
-7
src/applications/repository/query/PhabricatorRepositorySearchEngine.php
-7
src/applications/repository/query/PhabricatorRepositorySearchEngine.php
···
24
24
id(new PhabricatorSearchStringListField())
25
25
->setLabel(pht('Callsigns'))
26
26
->setKey('callsigns'),
27
-
id(new PhabricatorSearchTextField())
28
-
->setLabel(pht('Name Contains'))
29
-
->setKey('name'),
30
27
id(new PhabricatorSearchSelectField())
31
28
->setLabel(pht('Status'))
32
29
->setKey('status')
···
70
67
71
68
if ($map['types']) {
72
69
$query->withTypes($map['types']);
73
-
}
74
-
75
-
if (strlen($map['name'])) {
76
-
$query->withNameContains($map['name']);
77
70
}
78
71
79
72
if ($map['uris']) {