@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Maniphest - load subscribers in getApplicationTransactionsObject
Summary: Fixes T6734. This is a very generic fix, which basically attaches the subscribers if necessary. This seems like a good idea given there's some crazy generic code doing this sort of thing? This would end up being a new pattern for these types of objects that may be loaded by a general object query but then get some editor action against them.
Test Plan: I can't actually reproduce this in my sandbox so I'll verify live again.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T6734
Differential Revision: https://secure.phabricator.com/D10976
+2
-1
+2
-1
src/applications/herald/adapter/HeraldManiphestTaskAdapter.php
+2
-1
src/applications/herald/adapter/HeraldManiphestTaskAdapter.php
···
139
139
case self::FIELD_ASSIGNEE:
140
140
return $this->getTask()->getOwnerPHID();
141
141
case self::FIELD_CC:
142
-
return $this->getTask()->getSubscriberPHIDs();
142
+
return PhabricatorSubscribersQuery::loadSubscribersForPHID(
143
+
$this->getTask()->getPHID());
143
144
case self::FIELD_PROJECTS:
144
145
return PhabricatorEdgeQuery::loadDestinationPHIDs(
145
146
$this->getTask()->getPHID(),