@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Pass exception to PhutilProxyException
Summary: Fixes T12243. That error occured due to network flakiness with some mounted filesystems so I'm not sure how best to simulate it. But you can look and see that the PhutilProxyException does indeed expect an exception as its second arg.
Test Plan: Look at method signature... look at callsite... now back at the method. Smile and nod.
Reviewers: #blessed_reviewers, yelirekim, epriestley
Reviewed By: #blessed_reviewers, epriestley
Subscribers: epriestley
Maniphest Tasks: T12243
Differential Revision: https://secure.phabricator.com/D17335
+2
-1
+2
-1
src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php
+2
-1
src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php
···
335
335
pht(
336
336
'Failed to acquire write lock after waiting %s second(s). You '.
337
337
'may be able to retry later.',
338
-
new PhutilNumber($lock_wait)));
338
+
new PhutilNumber($lock_wait)),
339
+
$ex);
339
340
}
340
341
341
342
$versions = PhabricatorRepositoryWorkingCopyVersion::loadVersions(