@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a bad getStatus() call which is fataling during Herald rule evaluation
Summary: Hit this while `arc diff`'ing something which is triggering 2+ rules which add reviewers, I think.
Test Plan: Dug this out of a production stack trace; will push and `arc diff` again.
Reviewers: chad
Reviewed By: chad
Differential Revision: https://secure.phabricator.com/D17534
+1
-1
+1
-1
src/applications/differential/herald/DifferentialReviewersHeraldAction.php
+1
-1
src/applications/differential/herald/DifferentialReviewersHeraldAction.php
···
57
57
// If we're applying a stronger status (usually, upgrading a reviewer
58
58
// into a blocking reviewer), skip this check so we apply the change.
59
59
$old_strength = DifferentialReviewerStatus::getStatusStrength(
60
-
$reviewers[$phid]->getStatus());
60
+
$reviewers[$phid]->getReviewerStatus());
61
61
if ($old_strength <= $new_strength) {
62
62
continue;
63
63
}