recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Correctly focus elements in Workflow dialogs

Summary:
JX.Workflow does a JX.DOM.find() for the sigil __default__, but fails because we
render with phutil_render_tag() instead of javelin_render_tag() so sigils are
not converted correctly.

Test Plan:
Opened an inline comment in differential, got focus on the <textarea />

Reviewed By: tuomaspelkonen
Reviewers: tuomaspelkonen
CC: aran, tuomaspelkonen, epriestley
Differential Revision: 259

epriestley e32fd1a8 d5dfa5fa

+1 -1
+1 -1
src/view/dialog/AphrontDialogView.php
··· 83 83 84 84 $buttons = array(); 85 85 if ($this->submitButton) { 86 - $buttons[] = phutil_render_tag( 86 + $buttons[] = javelin_render_tag( 87 87 'button', 88 88 array( 89 89 'name' => '__submit__',