@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up Multirow Manager UI
Summary: Fixes T4234 (Policy and Herald). I will have an additional diff for Maniphest Batch Editor, which looks jank in many other ways.
Test Plan:
Test editing a policy and some herald rules. Stuff lines up better.
{F235086}
{F235087}
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T4234
Differential Revision: https://secure.phabricator.com/D10864
+38
-25
+15
-15
resources/celerity/map.php
+15
-15
resources/celerity/map.php
···
7
7
*/
8
8
return array(
9
9
'names' => array(
10
-
'core.pkg.css' => '5b6531df',
10
+
'core.pkg.css' => '0784ef1d',
11
11
'core.pkg.js' => 'cbdbd552',
12
12
'darkconsole.pkg.js' => 'df001cab',
13
13
'differential.pkg.css' => '8af45893',
···
68
68
'rsrc/css/application/flag/flag.css' => '5337623f',
69
69
'rsrc/css/application/harbormaster/harbormaster.css' => '49d64eb4',
70
70
'rsrc/css/application/herald/herald-test.css' => '778b008e',
71
-
'rsrc/css/application/herald/herald.css' => 'c544dd1c',
71
+
'rsrc/css/application/herald/herald.css' => '826075fa',
72
72
'rsrc/css/application/maniphest/batch-editor.css' => '8f380ebc',
73
73
'rsrc/css/application/maniphest/report.css' => '6fc16517',
74
74
'rsrc/css/application/maniphest/task-edit.css' => '8e23031b',
···
85
85
'rsrc/css/application/phortune/phortune.css' => '9149f103',
86
86
'rsrc/css/application/phrequent/phrequent.css' => 'ffc185ad',
87
87
'rsrc/css/application/phriction/phriction-document-css.css' => '7d7f0071',
88
-
'rsrc/css/application/policy/policy-edit.css' => '05cca26a',
88
+
'rsrc/css/application/policy/policy-edit.css' => '815c66f7',
89
89
'rsrc/css/application/policy/policy-transaction-detail.css' => '82100a43',
90
90
'rsrc/css/application/policy/policy.css' => '957ea14c',
91
91
'rsrc/css/application/ponder/comments.css' => '6cdccea7',
···
126
126
'rsrc/css/phui/phui-document.css' => 'a5615198',
127
127
'rsrc/css/phui/phui-feed-story.css' => 'dd3c5ff5',
128
128
'rsrc/css/phui/phui-fontkit.css' => '9c3d2dce',
129
-
'rsrc/css/phui/phui-form-view.css' => 'a3efd18c',
129
+
'rsrc/css/phui/phui-form-view.css' => 'c875f46c',
130
130
'rsrc/css/phui/phui-form.css' => 'b78ec020',
131
131
'rsrc/css/phui/phui-header-view.css' => '39594ac0',
132
132
'rsrc/css/phui/phui-icon.css' => 'b4963a4f',
···
443
443
'rsrc/js/core/Hovercard.js' => '7e8468ae',
444
444
'rsrc/js/core/KeyboardShortcut.js' => '1ae869f2',
445
445
'rsrc/js/core/KeyboardShortcutManager.js' => 'ad7a69ca',
446
-
'rsrc/js/core/MultirowRowManager.js' => '41e47dea',
446
+
'rsrc/js/core/MultirowRowManager.js' => 'b5d57730',
447
447
'rsrc/js/core/Notification.js' => '0c6946e7',
448
448
'rsrc/js/core/Prefab.js' => 'bbae734c',
449
449
'rsrc/js/core/ShapedRequest.js' => '7cbe244b',
···
536
536
'font-source-sans-pro' => '91d53463',
537
537
'global-drag-and-drop-css' => '697324ad',
538
538
'harbormaster-css' => '49d64eb4',
539
-
'herald-css' => 'c544dd1c',
539
+
'herald-css' => '826075fa',
540
540
'herald-rule-editor' => '335fd41f',
541
541
'herald-test-css' => '778b008e',
542
542
'inline-comment-summary-css' => '8cfd34e8',
···
697
697
'maniphest-report-css' => '6fc16517',
698
698
'maniphest-task-edit-css' => '8e23031b',
699
699
'maniphest-task-summary-css' => '13ed8360',
700
-
'multirow-row-manager' => '41e47dea',
700
+
'multirow-row-manager' => 'b5d57730',
701
701
'owners-path-editor' => 'aa1733d0',
702
702
'owners-path-editor-css' => '2f00933b',
703
703
'paste-css' => 'aa1767d1',
···
776
776
'phui-font-icon-base-css' => '3dad2ae3',
777
777
'phui-fontkit-css' => '9c3d2dce',
778
778
'phui-form-css' => 'b78ec020',
779
-
'phui-form-view-css' => 'a3efd18c',
779
+
'phui-form-view-css' => 'c875f46c',
780
780
'phui-header-view-css' => '39594ac0',
781
781
'phui-icon-view-css' => 'b4963a4f',
782
782
'phui-image-mask-css' => '5a8b09c8',
···
798
798
'phuix-action-view' => '6e8cefa4',
799
799
'phuix-dropdown-menu' => 'bd4c8dca',
800
800
'policy-css' => '957ea14c',
801
-
'policy-edit-css' => '05cca26a',
801
+
'policy-edit-css' => '815c66f7',
802
802
'policy-transaction-detail-css' => '82100a43',
803
803
'ponder-comment-table-css' => '6cdccea7',
804
804
'ponder-feed-view-css' => 'e62615b6',
···
1095
1095
'phuix-dropdown-menu',
1096
1096
'phuix-action-list-view',
1097
1097
'phuix-action-view',
1098
-
),
1099
-
'41e47dea' => array(
1100
-
'javelin-install',
1101
-
'javelin-stratcom',
1102
-
'javelin-dom',
1103
-
'javelin-util',
1104
1098
),
1105
1099
'44168bad' => array(
1106
1100
'javelin-behavior',
···
1604
1598
'b5c256b8' => array(
1605
1599
'javelin-install',
1606
1600
'javelin-dom',
1601
+
),
1602
+
'b5d57730' => array(
1603
+
'javelin-install',
1604
+
'javelin-stratcom',
1605
+
'javelin-dom',
1606
+
'javelin-util',
1607
1607
),
1608
1608
'b6d401d6' => array(
1609
1609
'javelin-dom',
+6
-1
webroot/rsrc/css/application/herald/herald.css
+6
-1
webroot/rsrc/css/application/herald/herald.css
···
17
17
18
18
.herald-action-table td,
19
19
.herald-condition-table td {
20
-
padding: 2px 4px;
20
+
padding: 2px 8px 2px 0;
21
21
vertical-align: middle;
22
+
}
23
+
24
+
.herald-action-table td.remove-column,
25
+
.herald-condition-table td.remove-column {
26
+
padding: 2px 0 2px 4px;
22
27
}
23
28
24
29
.herald-condition-table td.value {
+5
-1
webroot/rsrc/css/application/policy/policy-edit.css
+5
-1
webroot/rsrc/css/application/policy/policy-edit.css
+9
-5
webroot/rsrc/css/phui/phui-form-view.css
+9
-5
webroot/rsrc/css/phui/phui-form-view.css
···
252
252
}
253
253
254
254
.phui-form-inset {
255
-
margin: 0 0 8px;
255
+
margin: 4px 0 8px;
256
256
padding: 8px;
257
-
background: #fff;
258
-
border: 1px solid #d4dae0;
257
+
background: #f7f9fd;
258
+
border: 1px solid {$lightblueborder};
259
+
border-bottom: 1px solid {$blueborder};
260
+
border-radius: 3px;
259
261
}
260
262
261
263
.phui-form-inset h1 {
262
-
color: {$greytext};
263
-
font-weight: normal;
264
+
color: {$bluetext};
264
265
padding-bottom: 8px;
266
+
margin-bottom: 8px;
267
+
font-size: 14px;
268
+
border-bottom: 1px solid {$thinblueborder};
265
269
}
266
270
267
271
.aphront-form-drag-and-drop-file-list {
+3
-3
webroot/rsrc/js/core/MultirowRowManager.js
+3
-3
webroot/rsrc/js/core/MultirowRowManager.js
···
57
57
58
58
var removeButton = JX.$N(
59
59
'td',
60
-
{},
60
+
{ className: 'remove-column' },
61
61
JX.$N(
62
62
'a',
63
-
{ className: 'button',
63
+
{ className: 'button simple',
64
64
sigil: JX.MultirowRowManager._removeSigil
65
65
},
66
-
'-'));
66
+
'Remove'));
67
67
68
68
JX.DOM.appendContent(row, removeButton);
69
69
return row;