@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Alternate fix for Firefox triple click selection
Summary:
Fixes T10905. This reverts D15823, which didn't work well for tasks with very long titles (the title would break as a block element).
This is slightly more magic but works with long titles.
Test Plan: Did everything from D15823, but also with long titles. Triple-click, wrapping, and mobile/device worked in Safari, Firefox and Chrome.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10905
Differential Revision: https://secure.phabricator.com/D15824
+6
-15
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
7
7
*/
8
8
return array(
9
9
'names' => array(
10
-
'core.pkg.css' => 'ede6bf7a',
10
+
'core.pkg.css' => 'b729f9f5',
11
11
'core.pkg.js' => '6972d365',
12
12
'darkconsole.pkg.js' => 'e7393ebb',
13
13
'differential.pkg.css' => '7ba78475',
···
136
136
'rsrc/css/phui/phui-form-view.css' => '6a51768e',
137
137
'rsrc/css/phui/phui-form.css' => 'aac1d51d',
138
138
'rsrc/css/phui/phui-head-thing.css' => 'fd311e5f',
139
-
'rsrc/css/phui/phui-header-view.css' => '9961e480',
139
+
'rsrc/css/phui/phui-header-view.css' => '4c7dd8f5',
140
140
'rsrc/css/phui/phui-hovercard.css' => 'de1a2119',
141
141
'rsrc/css/phui/phui-icon-set-selector.css' => '1ab67aad',
142
142
'rsrc/css/phui/phui-icon.css' => '3f33ab57',
···
829
829
'phui-form-css' => 'aac1d51d',
830
830
'phui-form-view-css' => '6a51768e',
831
831
'phui-head-thing-view-css' => 'fd311e5f',
832
-
'phui-header-view-css' => '9961e480',
832
+
'phui-header-view-css' => '4c7dd8f5',
833
833
'phui-hovercard' => '1bd28176',
834
834
'phui-hovercard-view-css' => 'de1a2119',
835
835
'phui-icon-set-selector-css' => '1ab67aad',
-9
src/view/phui/PHUIHeaderView.php
-9
src/view/phui/PHUIHeaderView.php
···
316
316
$header_content);
317
317
}
318
318
319
-
// This wrapper element allows titles to be triple-clicked to select them
320
-
// in Firefox. See T10905 for discussion.
321
-
$header_content = phutil_tag(
322
-
'span',
323
-
array(
324
-
'class' => 'phui-header-content',
325
-
),
326
-
$header_content);
327
-
328
319
$left[] = phutil_tag(
329
320
'span',
330
321
array(
+3
-3
webroot/rsrc/css/phui/phui-header-view.css
+3
-3
webroot/rsrc/css/phui/phui-header-view.css
···
78
78
.phui-header-header .phui-header-icon {
79
79
margin-right: 8px;
80
80
color: {$lightbluetext};
81
-
}
82
81
83
-
.phui-header-content {
84
-
display: inline-block;
82
+
/* This allows the header text to be triple-clicked to select it in Firefox,
83
+
see T10905 for discussion. */
84
+
display: inline;
85
85
}
86
86
87
87
.phui-object-box .phui-header-tall .phui-header-header,