@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Normalize AuditStatusConstant Colors
Summary: Ref T6345, This adds more consistent color choices to match how Phabricator generally works across Differential/Diffusion per user statuses.
Test Plan: Review a few Audits in my sandbox.
Reviewers: epriestley, btrahan
Reviewed By: btrahan
Subscribers: Korvin, epriestley
Maniphest Tasks: T6345
Differential Revision: https://secure.phabricator.com/D10726
+39
-53
+33
-1
src/applications/audit/constants/PhabricatorAuditStatusConstants.php
+33
-1
src/applications/audit/constants/PhabricatorAuditStatusConstants.php
···
38
38
$color = 'red';
39
39
break;
40
40
case self::AUDIT_REQUIRED:
41
+
case self::AUDIT_REQUESTED:
41
42
$color = 'orange';
42
43
break;
43
44
case self::ACCEPTED:
44
45
$color = 'green';
45
46
break;
47
+
case self::AUDIT_NOT_REQUIRED:
48
+
$color = 'blue';
49
+
break;
50
+
case self::RESIGNED:
51
+
case self::CLOSED:
52
+
$color = 'dark';
53
+
break;
46
54
default:
47
-
$color = null;
55
+
$color = 'bluegrey';
48
56
break;
49
57
}
50
58
return $color;
59
+
}
60
+
61
+
public static function getStatusIcon($code) {
62
+
switch ($code) {
63
+
case PhabricatorAuditStatusConstants::AUDIT_NOT_REQUIRED:
64
+
case PhabricatorAuditStatusConstants::RESIGNED:
65
+
$icon = PHUIStatusItemView::ICON_OPEN;
66
+
break;
67
+
case PhabricatorAuditStatusConstants::AUDIT_REQUIRED:
68
+
case PhabricatorAuditStatusConstants::AUDIT_REQUESTED:
69
+
$icon = PHUIStatusItemView::ICON_WARNING;
70
+
break;
71
+
case PhabricatorAuditStatusConstants::CONCERNED:
72
+
$icon = PHUIStatusItemView::ICON_REJECT;
73
+
break;
74
+
case PhabricatorAuditStatusConstants::ACCEPTED:
75
+
case PhabricatorAuditStatusConstants::CLOSED:
76
+
$icon = PHUIStatusItemView::ICON_ACCEPT;
77
+
break;
78
+
default:
79
+
$icon = PHUIStatusItemView::ICON_QUESTION;
80
+
break;
81
+
}
82
+
return $icon;
51
83
}
52
84
53
85
public static function getOpenStatusConstants() {
+1
-1
src/applications/differential/view/DifferentialReviewersView.php
+1
-1
src/applications/differential/view/DifferentialReviewersView.php
+5
-51
src/applications/diffusion/controller/DiffusionCommitController.php
+5
-51
src/applications/diffusion/controller/DiffusionCommitController.php
···
1055
1055
1056
1056
$view = new PHUIStatusListView();
1057
1057
foreach ($audit_requests as $request) {
1058
+
$code = $request->getAuditStatus();
1058
1059
$item = new PHUIStatusItemView();
1059
-
1060
-
switch ($request->getAuditStatus()) {
1061
-
case PhabricatorAuditStatusConstants::AUDIT_NOT_REQUIRED:
1062
-
$item->setIcon(
1063
-
PHUIStatusItemView::ICON_OPEN,
1064
-
'blue',
1065
-
pht('Commented'));
1066
-
break;
1067
-
case PhabricatorAuditStatusConstants::AUDIT_REQUIRED:
1068
-
$item->setIcon(
1069
-
PHUIStatusItemView::ICON_WARNING,
1070
-
'blue',
1071
-
pht('Audit Required'));
1072
-
break;
1073
-
case PhabricatorAuditStatusConstants::CONCERNED:
1074
-
$item->setIcon(
1075
-
PHUIStatusItemView::ICON_REJECT,
1076
-
'red',
1077
-
pht('Concern Raised'));
1078
-
break;
1079
-
case PhabricatorAuditStatusConstants::ACCEPTED:
1080
-
$item->setIcon(
1081
-
PHUIStatusItemView::ICON_ACCEPT,
1082
-
'green',
1083
-
pht('Accepted'));
1084
-
break;
1085
-
case PhabricatorAuditStatusConstants::AUDIT_REQUESTED:
1086
-
$item->setIcon(
1087
-
PHUIStatusItemView::ICON_WARNING,
1088
-
'dark',
1089
-
pht('Audit Requested'));
1090
-
break;
1091
-
case PhabricatorAuditStatusConstants::RESIGNED:
1092
-
$item->setIcon(
1093
-
PHUIStatusItemView::ICON_OPEN,
1094
-
'dark',
1095
-
pht('Resigned'));
1096
-
break;
1097
-
case PhabricatorAuditStatusConstants::CLOSED:
1098
-
$item->setIcon(
1099
-
PHUIStatusItemView::ICON_ACCEPT,
1100
-
'blue',
1101
-
pht('Closed'));
1102
-
break;
1103
-
default:
1104
-
$item->setIcon(
1105
-
PHUIStatusItemView::ICON_QUESTION,
1106
-
'dark',
1107
-
pht('%s?', $request->getAuditStatus()));
1108
-
break;
1109
-
}
1060
+
$item->setIcon(
1061
+
PhabricatorAuditStatusConstants::getStatusIcon($code),
1062
+
PhabricatorAuditStatusConstants::getStatusColor($code),
1063
+
PhabricatorAuditStatusConstants::getStatusName($code));
1110
1064
1111
1065
$note = array();
1112
1066
foreach ($request->getAuditReasons() as $reason) {