recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Show daemon arguments with `./bin/phd status`.

Summary: Fixes T4735. When running `./bin/phd`, show daemon arguments.

Test Plan:
```
./bin/phd status
PID Started Daemon Arguments
12711 May 20 2014, 9:02:52 AM PhabricatorRepositoryPullLocalDaemon []
12716 May 20 2014, 9:02:52 AM PhabricatorGarbageCollectorDaemon []
12733 May 20 2014, 9:02:53 AM PhabricatorTaskmasterDaemon []
12768 May 20 2014, 9:02:53 AM PhabricatorTaskmasterDaemon []
12775 May 20 2014, 9:02:53 AM PhabricatorTaskmasterDaemon []
12780 May 20 2014, 9:02:54 AM PhabricatorTaskmasterDaemon []
12838 May 20 2014, 9:02:54 AM PhabricatorFactDaemon []
13436 May 20 2014, 9:03:23 AM PhabricatorRepositoryPullLocalDaemon ["X","--not","Y"]
```

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Maniphest Tasks: T4735

Differential Revision: https://secure.phabricator.com/D9208

authored by

Joshua Spence and committed by
epriestley eba11238 b6d15377

+14 -6
+8 -6
src/applications/daemon/management/PhabricatorDaemonManagementStatusWorkflow.php
··· 23 23 24 24 $status = 0; 25 25 printf( 26 - "%-5s\t%-24s\t%s\n", 27 - "PID", 28 - "Started", 29 - "Daemon"); 26 + "%-5s\t%-24s\t%-50s%s\n", 27 + 'PID', 28 + 'Started', 29 + 'Daemon', 30 + 'Arguments'); 30 31 foreach ($daemons as $daemon) { 31 32 $name = $daemon->getName(); 32 33 if (!$daemon->isRunning()) { ··· 35 36 $name = '<DEAD> '.$name; 36 37 } 37 38 printf( 38 - "%5s\t%-24s\t%s\n", 39 + "%5s\t%-24s\t%-50s%s\n", 39 40 $daemon->getPID(), 40 41 $daemon->getEpochStarted() 41 42 ? date('M j Y, g:i:s A', $daemon->getEpochStarted()) 42 43 : null, 43 - $name); 44 + $name, 45 + csprintf('%LR', $daemon->getArgv())); 44 46 } 45 47 46 48 return $status;
+6
src/infrastructure/daemon/control/PhabricatorDaemonReference.php
··· 3 3 final class PhabricatorDaemonReference { 4 4 5 5 private $name; 6 + private $argv; 6 7 private $pid; 7 8 private $start; 8 9 private $pidFile; ··· 13 14 $ref = new PhabricatorDaemonReference(); 14 15 15 16 $ref->name = idx($dict, 'name', 'Unknown'); 17 + $ref->argv = idx($dict, 'argv', array()); 16 18 $ref->pid = idx($dict, 'pid'); 17 19 $ref->start = idx($dict, 'start'); 18 20 ··· 54 56 55 57 public function getName() { 56 58 return $this->name; 59 + } 60 + 61 + public function getArgv() { 62 + return $this->argv; 57 63 } 58 64 59 65 public function getEpochStarted() {