@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix Ponder Answer email reply handler

Summary: Should fix all email reply issues, but no solid means of testing at home (how do you local reply test?)

Test Plan: Check for answer mail in /mail/ and see proper headers. Make sure question mail works too.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T3846

Differential Revision: https://secure.phabricator.com/D13951

+17 -23
+7 -6
src/applications/ponder/editor/PonderAnswerEditor.php
··· 86 86 } 87 87 88 88 protected function buildReplyHandler(PhabricatorLiskDAO $object) { 89 - $question = $object->getQuestion(); 90 - return id(new PonderQuestionReplyHandler()) 91 - ->setMailReceiver($question); 89 + return id(new PonderAnswerReplyHandler()) 90 + ->setMailReceiver($object); 92 91 } 93 92 94 93 protected function buildMailTemplate(PhabricatorLiskDAO $object) { 95 - $question = $object->getQuestion(); 96 - return parent::buildMailTemplate($question); 94 + $id = $object->getID(); 95 + 96 + return id(new PhabricatorMetaMTAMail()) 97 + ->setSubject("ANSR{$id}") 98 + ->addHeader('Thread-Topic', "ANSR{$id}"); 97 99 } 98 - 99 100 100 101 protected function buildMailBody( 101 102 PhabricatorLiskDAO $object,
-17
src/applications/ponder/editor/PonderEditor.php
··· 7 7 return 'PhabricatorPonderApplication'; 8 8 } 9 9 10 - protected function shouldPublishFeedStory( 11 - PhabricatorLiskDAO $object, 12 - array $xactions) { 13 - return true; 14 - } 15 - 16 - protected function buildMailTemplate(PhabricatorLiskDAO $object) { 17 - $id = $object->getID(); 18 - $title = $object->getTitle(); 19 - $original_title = $object->getOriginalTitle(); 20 - 21 - return id(new PhabricatorMetaMTAMail()) 22 - ->setSubject("Q{$id}: {$title}") 23 - ->addHeader('Thread-Topic', "Q{$id}: {$original_title}"); 24 - } 25 - 26 - 27 10 protected function getMailTo(PhabricatorLiskDAO $object) { 28 11 return array( 29 12 $object->getAuthorPHID(),
+10
src/applications/ponder/editor/PonderQuestionEditor.php
··· 231 231 ->setMailReceiver($object); 232 232 } 233 233 234 + protected function buildMailTemplate(PhabricatorLiskDAO $object) { 235 + $id = $object->getID(); 236 + $title = $object->getTitle(); 237 + $original_title = $object->getOriginalTitle(); 238 + 239 + return id(new PhabricatorMetaMTAMail()) 240 + ->setSubject("Q{$id}: {$title}") 241 + ->addHeader('Thread-Topic', "Q{$id}: {$original_title}"); 242 + } 243 + 234 244 protected function buildMailBody( 235 245 PhabricatorLiskDAO $object, 236 246 array $xactions) {