@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Only show member/watcher notes on Members page in Projects
Summary: Restricts the view of the membership privileges to just the Members page itself, and not other pages like Home/Details.
Test Plan: Test Home, Test Members, see correct layouts.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D17896
+17
-7
+4
-2
src/applications/project/controller/PhabricatorProjectMembersViewController.php
+4
-2
src/applications/project/controller/PhabricatorProjectMembersViewController.php
···
26
26
->setUser($viewer)
27
27
->setProject($project)
28
28
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
29
-
->setUserPHIDs($project->getMemberPHIDs());
29
+
->setUserPHIDs($project->getMemberPHIDs())
30
+
->setShowNote(true);
30
31
31
32
$watcher_list = id(new PhabricatorProjectWatcherListView())
32
33
->setUser($viewer)
33
34
->setProject($project)
34
35
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
35
-
->setUserPHIDs($project->getWatcherPHIDs());
36
+
->setUserPHIDs($project->getWatcherPHIDs())
37
+
->setShowNote(true);
36
38
37
39
$nav = $this->getProfileMenu();
38
40
$nav->selectFilter(PhabricatorProject::ITEM_MEMBERS);
+13
-5
src/applications/project/view/PhabricatorProjectUserListView.php
+13
-5
src/applications/project/view/PhabricatorProjectUserListView.php
···
6
6
private $userPHIDs;
7
7
private $limit;
8
8
private $background;
9
+
private $showNote;
9
10
10
11
public function setProject(PhabricatorProject $project) {
11
12
$this->project = $project;
···
36
37
37
38
public function setBackground($color) {
38
39
$this->background = $color;
40
+
return $this;
41
+
}
42
+
43
+
public function setShowNote($show) {
44
+
$this->showNote = $show;
39
45
return $this;
40
46
}
41
47
···
136
142
->setHeader($header)
137
143
->setObjectList($list);
138
144
139
-
if ($this->getMembershipNote()) {
140
-
$info = id(new PHUIInfoView())
141
-
->setSeverity(PHUIInfoView::SEVERITY_PLAIN)
142
-
->appendChild($this->getMembershipNote());
143
-
$box->setInfoView($info);
145
+
if ($this->showNote) {
146
+
if ($this->getMembershipNote()) {
147
+
$info = id(new PHUIInfoView())
148
+
->setSeverity(PHUIInfoView::SEVERITY_PLAIN)
149
+
->appendChild($this->getMembershipNote());
150
+
$box->setInfoView($info);
151
+
}
144
152
}
145
153
146
154
if ($this->background) {