@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Legalpad - style NOTE IMPORTANT WARNING remarkup slightly differently
Summary: round them there corners, to create more of a "bubble" effect in legalpad. Ref T3116.
Test Plan: see screenshot, which demonstrates new style works
Reviewers: epriestley
Reviewed By: epriestley
CC: chad, Korvin, epriestley, aran
Maniphest Tasks: T3116
Differential Revision: https://secure.phabricator.com/D8060
+39
-9
+5
-3
resources/celerity/map.php
+5
-3
resources/celerity/map.php
···
7
7
return array(
8
8
'names' =>
9
9
array(
10
-
'core.pkg.css' => '5ad20a3f',
10
+
'core.pkg.css' => '63255578',
11
11
'core.pkg.js' => 'c907bd96',
12
12
'darkconsole.pkg.js' => 'ca8671ce',
13
13
'differential.pkg.css' => '5a65a762',
···
74
74
'rsrc/css/application/flag/flag.css' => '5337623f',
75
75
'rsrc/css/application/herald/herald-test.css' => '2b7d0f54',
76
76
'rsrc/css/application/herald/herald.css' => '59d48f01',
77
+
'rsrc/css/application/legalpad/legalpad-document.css' => 'c60a9d1e',
77
78
'rsrc/css/application/maniphest/batch-editor.css' => '78444bc1',
78
79
'rsrc/css/application/maniphest/report.css' => '6fc16517',
79
80
'rsrc/css/application/maniphest/task-edit.css' => '8e23031b',
···
113
114
'rsrc/css/application/tokens/tokens.css' => 'fb286311',
114
115
'rsrc/css/application/uiexample/example.css' => '4741b891',
115
116
'rsrc/css/core/core.css' => 'da26ddb2',
116
-
'rsrc/css/core/remarkup.css' => 'bec51bf1',
117
+
'rsrc/css/core/remarkup.css' => 'ca7f2265',
117
118
'rsrc/css/core/syntax.css' => '3c18c1cb',
118
119
'rsrc/css/core/z-index.css' => '1bbbd4f1',
119
120
'rsrc/css/diviner/diviner-shared.css' => 'be90f718',
···
655
656
'javelin-view-renderer' => '77461fd6',
656
657
'javelin-view-visitor' => 'ca704f2b',
657
658
'javelin-workflow' => 'd16edeae',
659
+
'legalpad-document-css' => 'c60a9d1e',
658
660
'lightbox-attachment-css' => '686f8885',
659
661
'maniphest-batch-editor' => '78444bc1',
660
662
'maniphest-report-css' => '6fc16517',
···
700
702
'phabricator-prefab' => '9eaf0bfa',
701
703
'phabricator-profile-css' => '3a7e04ca',
702
704
'phabricator-project-tag-css' => '095c9404',
703
-
'phabricator-remarkup-css' => 'bec51bf1',
705
+
'phabricator-remarkup-css' => 'ca7f2265',
704
706
'phabricator-search-results-css' => 'f240504c',
705
707
'phabricator-settings-css' => 'ea8f5915',
706
708
'phabricator-shaped-request' => 'dfa181a4',
+14
-6
src/applications/legalpad/controller/LegalpadDocumentSignController.php
+14
-6
src/applications/legalpad/controller/LegalpadDocumentSignController.php
···
177
177
->setHeader($title);
178
178
179
179
$content = array(
180
-
id(new PHUIDocumentView())
181
-
->setHeader($header)
182
-
->appendChild($this->buildDocument($engine, $document_body)),
180
+
$this->buildDocument(
181
+
$header,
182
+
$engine,
183
+
$document_body),
183
184
$this->buildSignatureForm(
184
185
$document_body,
185
186
$signature,
···
199
200
}
200
201
201
202
private function buildDocument(
202
-
PhabricatorMarkupEngine
203
-
$engine, LegalpadDocumentBody $body) {
203
+
PHUIHeaderView $header,
204
+
PhabricatorMarkupEngine $engine,
205
+
LegalpadDocumentBody $body) {
204
206
205
-
return $engine->getOutput($body, LegalpadDocumentBody::MARKUP_FIELD_TEXT);
207
+
$this->requireResource('legalpad-document-css');
208
+
return id(new PHUIDocumentView())
209
+
->addClass('legalpad')
210
+
->setHeader($header)
211
+
->appendChild($engine->getOutput(
212
+
$body,
213
+
LegalpadDocumentBody::MARKUP_FIELD_TEXT));
206
214
}
207
215
208
216
private function buildSignatureForm(
+2
src/applications/legalpad/controller/LegalpadDocumentViewController.php
+2
src/applications/legalpad/controller/LegalpadDocumentViewController.php
···
110
110
PhabricatorMarkupEngine
111
111
$engine, LegalpadDocumentBody $body) {
112
112
113
+
$this->requireResource('legalpad-document-css');
113
114
$view = new PHUIPropertyListView();
115
+
$view->addClass('legalpad');
114
116
$view->addSectionHeader(pht('Document'));
115
117
$view->addTextContent(
116
118
$engine->getOutput($body, LegalpadDocumentBody::MARKUP_FIELD_TEXT));
+18
webroot/rsrc/css/application/legalpad/legalpad-document.css
+18
webroot/rsrc/css/application/legalpad/legalpad-document.css
···
1
+
/**
2
+
* @provides legalpad-document-css
3
+
*/
4
+
5
+
.legalpad .phabricator-remarkup .remarkup-note {
6
+
border-radius: 14px;
7
+
-moz-border-radius: 14px;
8
+
}
9
+
10
+
.legalpad .phabricator-remarkup .remarkup-warning {
11
+
border-radius: 14px;
12
+
-moz-border-radius: 14px;
13
+
}
14
+
15
+
.legalpad .phabricator-remarkup .remarkup-important {
16
+
border-radius: 14px;
17
+
-moz-border-radius: 14px;
18
+
}