When cancelling addition of an Almanac interface, return to the Device page

@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge

phorge phabricator

fork

Summary:
Fixes T13184. In Almanac, interfaces are always added to devices. However, if you "Add New Interface" and then "Cancel", you go to the nonexistent `/interface/` page.

Instead, return to the device page.

Test Plan: From a device page, clicked "Add Interface" and then "Cancel". Ended up back where I was.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13184

Differential Revision: https://secure.phabricator.com/D19573

epriestley 7 years ago fb3ae72e b86dae62

1 changed file

expand all

src

applications

almanac

editor

AlmanacInterfaceEditEngine.php

src/applications/almanac/editor/AlmanacInterfaceEditEngine.php

··· 127 127 } 128 128 129 129 protected function getObjectCreateCancelURI($object) { 130 + if ($this->getDevice()) { 131 + return $this->getDevice()->getURI(); 132 + } 130 133 return '/almanac/interface/'; 131 134 } 132 135

Configure Feed

Configure Feed