@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Move revisions without reviewers to author's queue
Summary:
If the revision doesn't have reviewers then it's really not waiting on someone else and the author must take an action.
An improvement would be to check if the reviewers are not disabled but that would require loading their handles.
Test Plan:
/
/differential/
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin, s.o.butler
Differential Revision: https://secure.phabricator.com/D5046
+4
+1
src/applications/differential/application/PhabricatorApplicationDifferential.php
+1
src/applications/differential/application/PhabricatorApplicationDifferential.php
+3
src/applications/differential/query/DifferentialRevisionQuery.php
+3
src/applications/differential/query/DifferentialRevisionQuery.php
···
903
903
foreach ($revisions as $revision) {
904
904
$needs_review = ($revision->getStatus() == $status_review);
905
905
$filter_is_author = in_array($revision->getAuthorPHID(), $user_phids);
906
+
if (!$revision->getReviewers()) {
907
+
$needs_review = false;
908
+
}
906
909
907
910
// If exactly one of "needs review" and "the user is the author" is
908
911
// true, the user needs to act on it. Otherwise, they're waiting on