@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Minor, really fix empty reference properties in diffusion
Summary:
Oh man, after the explode/map, the output when no references is actually
array(1) {
[0]=> string(0) ""
}
.. making the falsey check fail to work as expected.
Test Plan: same as D2892, but with a little more scrutiny :p
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D2893
authored by
David Reuss
and committed by
epriestley
fd94700d
19d58564
+2
-3
+2
-3
src/applications/diffusion/controller/DiffusionCommitController.php
+2
-3
src/applications/diffusion/controller/DiffusionCommitController.php
···
845
845
// %d, gives a weird output format
846
846
// similar to (remote/one, remote/two, remote/three)
847
847
$refs = trim($stdout, "() \n");
848
-
$refs = explode(',', $refs);
849
-
$refs = array_map('trim', $refs);
850
-
851
848
if (!$refs) {
852
849
return null;
853
850
}
851
+
$refs = explode(',', $refs);
852
+
$refs = array_map('trim', $refs);
854
853
855
854
$ref_links = array();
856
855
foreach ($refs as $ref) {