tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

phy: ti: phy-da8xx-usb: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230307115900.2293120-27-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Uwe Kleine-König and committed by
Vinod Koul 0196c847 b1d9ad66

+2 -4
+2 -4
drivers/phy/ti/phy-da8xx-usb.c
··· 211 211 return 0; 212 212 } 213 213 214 - static int da8xx_usb_phy_remove(struct platform_device *pdev) 214 + static void da8xx_usb_phy_remove(struct platform_device *pdev) 215 215 { 216 216 struct da8xx_usb_phy *d_phy = platform_get_drvdata(pdev); 217 217 ··· 219 219 phy_remove_lookup(d_phy->usb20_phy, "usb-phy", "musb-da8xx"); 220 220 phy_remove_lookup(d_phy->usb11_phy, "usb-phy", "ohci-da8xx"); 221 221 } 222 - 223 - return 0; 224 222 } 225 223 226 224 static const struct of_device_id da8xx_usb_phy_ids[] = { ··· 229 231 230 232 static struct platform_driver da8xx_usb_phy_driver = { 231 233 .probe = da8xx_usb_phy_probe, 232 - .remove = da8xx_usb_phy_remove, 234 + .remove_new = da8xx_usb_phy_remove, 233 235 .driver = { 234 236 .name = "da8xx-usb-phy", 235 237 .of_match_table = da8xx_usb_phy_ids,