tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

phy: ti: phy-am654-serdes: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230307115900.2293120-26-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Uwe Kleine-König and committed by
Vinod Koul b1d9ad66 80460691

+2 -4
+2 -4
drivers/phy/ti/phy-am654-serdes.c
··· 842 842 return ret; 843 843 } 844 844 845 - static int serdes_am654_remove(struct platform_device *pdev) 845 + static void serdes_am654_remove(struct platform_device *pdev) 846 846 { 847 847 struct serdes_am654 *am654_phy = platform_get_drvdata(pdev); 848 848 struct device_node *node = am654_phy->of_node; 849 849 850 850 pm_runtime_disable(&pdev->dev); 851 851 of_clk_del_provider(node); 852 - 853 - return 0; 854 852 } 855 853 856 854 static struct platform_driver serdes_am654_driver = { 857 855 .probe = serdes_am654_probe, 858 - .remove = serdes_am654_remove, 856 + .remove_new = serdes_am654_remove, 859 857 .driver = { 860 858 .name = "phy-am654", 861 859 .of_match_table = serdes_am654_id_table,