tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

coresight: Discard pm_runtime_put() return values

Failing a debugfs write due to pm_runtime_put() returning a negative
value is not particularly useful.

Returning an error code from pm_runtime_put() merely means that it has
not queued up a work item to check whether or not the device can be
suspended and there are many perfectly valid situations in which that
can happen, like after writing "on" to the devices' runtime PM "control"
attribute in sysfs for one example. It also happens when the kernel
has been configured with CONFIG_PM unset, in which case
debug_disable_func() in the coresight driver will always return an
error.

For this reason, update debug_disable_func() to simply discard the
return value of pm_runtime_put(), change its return type to void, and
propagate that change to debug_func_knob_write().

This will facilitate a planned change of the pm_runtime_put() return
type to void in the future.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Link: https://patch.msgid.link/2058657.yKVeVyVuyW@rafael.j.wysocki

Rafael J. Wysocki 01eafcca d33976be

+4 -8
+4 -8
drivers/hwtracing/coresight/coresight-cpu-debug.c
··· 451 451 return ret; 452 452 } 453 453 454 - static int debug_disable_func(void) 454 + static void debug_disable_func(void) 455 455 { 456 456 struct debug_drvdata *drvdata; 457 - int cpu, ret, err = 0; 457 + int cpu; 458 458 459 459 /* 460 460 * Disable debug power domains, records the error and keep ··· 466 466 if (!drvdata) 467 467 continue; 468 468 469 - ret = pm_runtime_put(drvdata->dev); 470 - if (ret < 0) 471 - err = ret; 469 + pm_runtime_put(drvdata->dev); 472 470 } 473 - 474 - return err; 475 471 } 476 472 477 473 static ssize_t debug_func_knob_write(struct file *f, ··· 488 492 if (val) 489 493 ret = debug_enable_func(); 490 494 else 491 - ret = debug_disable_func(); 495 + debug_disable_func(); 492 496 493 497 if (ret) { 494 498 pr_err("%s: unable to %s debug function: %d\n",