tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mm/damon/tests/vaddr-kunit: handle alloc failures on damon_test_split_evenly_succ()

damon_test_split_evenly_succ() is assuming all dynamic memory allocation
in it will succeed. Those are indeed likely in the real use cases since
those allocations are too small to fail, but theoretically those could
fail. In the case, inappropriate memory access can happen. Fix it by
appropriately cleanup pre-allocated memory and skip the execution of the
remaining tests in the failure cases.

Link: https://lkml.kernel.org/r/20251101182021.74868-20-sj@kernel.org
Fixes: 17ccae8bb5c9 ("mm/damon: add kunit tests")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@google.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <stable@vger.kernel.org> [5.15+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

SeongJae Park and committed by
Andrew Morton 0a63a0e7 7890e5b5

+8 -1
+8 -1
mm/damon/tests/vaddr-kunit.h
··· 284 284 unsigned long start, unsigned long end, unsigned int nr_pieces) 285 285 { 286 286 struct damon_target *t = damon_new_target(); 287 - struct damon_region *r = damon_new_region(start, end); 287 + struct damon_region *r; 288 288 unsigned long expected_width = (end - start) / nr_pieces; 289 289 unsigned long i = 0; 290 290 291 + if (!t) 292 + kunit_skip(test, "target alloc fail"); 293 + r = damon_new_region(start, end); 294 + if (!r) { 295 + damon_free_target(t); 296 + kunit_skip(test, "region alloc fail"); 297 + } 291 298 damon_add_region(r, t); 292 299 KUNIT_EXPECT_EQ(test, 293 300 damon_va_evenly_split_region(t, r, nr_pieces), 0);