tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mm/damon/tests/vaddr-kunit: handle alloc failures in damon_test_split_evenly_fail()

damon_test_split_evenly_fail() is assuming all dynamic memory allocation
in it will succeed. Those are indeed likely in the real use cases since
those allocations are too small to fail, but theoretically those could
fail. In the case, inappropriate memory access can happen. Fix it by
appropriately cleanup pre-allocated memory and skip the execution of the
remaining tests in the failure cases.

Link: https://lkml.kernel.org/r/20251101182021.74868-19-sj@kernel.org
Fixes: 17ccae8bb5c9 ("mm/damon: add kunit tests")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@google.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <stable@vger.kernel.org> [5.15+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

SeongJae Park and committed by
Andrew Morton 7890e5b5 2b22d0fc

+10 -1
+10 -1
mm/damon/tests/vaddr-kunit.h
··· 256 256 unsigned long start, unsigned long end, unsigned int nr_pieces) 257 257 { 258 258 struct damon_target *t = damon_new_target(); 259 - struct damon_region *r = damon_new_region(start, end); 259 + struct damon_region *r; 260 + 261 + if (!t) 262 + kunit_skip(test, "target alloc fail"); 263 + 264 + r = damon_new_region(start, end); 265 + if (!r) { 266 + damon_free_target(t); 267 + kunit_skip(test, "region alloc fail"); 268 + } 260 269 261 270 damon_add_region(r, t); 262 271 KUNIT_EXPECT_EQ(test,