tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/xe/guc: Drop error messages about missing GuC logs

The GuC log snapshot code would complain loudly if there was no GuC
log to take a snapshot of or if the snapshot alloc failed. Originally,
this code was only called on demand when a user (or developer)
explicitly requested a dump of the log. Hence an error message was
useful.

However, it is now part of the general devcoredump file and is called
for any GPU hang. Most people don't care about GuC logs and GPU hangs
do not generally mean a kernel/GuC bug. More importantly, there are
valid situations where there is no GuC log, e.g. SRIOV VFs.

So drop the error message.

Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/3958
Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250113194405.2033085-1-John.C.Harrison@Intel.com

John Harrison 174e9ce0 11a64adc

+2 -6
+2 -6
drivers/gpu/drm/xe/xe_guc_log.c
··· 149 149 size_t remain; 150 150 int i; 151 151 152 - if (!log->bo) { 153 - xe_gt_err(gt, "GuC log buffer not allocated\n"); 152 + if (!log->bo) 154 153 return NULL; 155 - } 156 154 157 155 snapshot = xe_guc_log_snapshot_alloc(log, atomic); 158 - if (!snapshot) { 159 - xe_gt_err(gt, "GuC log snapshot not allocated\n"); 156 + if (!snapshot) 160 157 return NULL; 161 - } 162 158 163 159 remain = snapshot->size; 164 160 for (i = 0; i < snapshot->num_chunks; i++) {