Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mm/memcg: use kmem_cache when alloc memcg pernode info

When tracing mem_cgroup_per_node allocations with kmalloc ftrace:

kmalloc: call_site=mem_cgroup_css_alloc+0x1d8/0x5b4 ptr=00000000d798700c
bytes_req=2896 bytes_alloc=4096 gfp_flags=GFP_KERNEL|__GFP_ZERO node=0
accounted=false

This reveals the slab allocator provides 4096B chunks for 2896B
mem_cgroup_per_node due to:

1. The slab allocator predefines bucket sizes from 64B to 8096B
2. The mem_cgroup allocation size (2312B) falls between the 2KB and 4KB
slabs
3. The allocator rounds up to the nearest larger slab (4KB), resulting in
~1KB wasted memory per memcg alloc - per node.

This patch introduces a dedicated kmem_cache for mem_cgroup structs,
achieving precise memory allocation. Post-patch ftrace verification shows:

kmem_cache_alloc: call_site=mem_cgroup_css_alloc+0x1b8/0x5d4
ptr=000000002989e63a bytes_req=2896 bytes_alloc=2944
gfp_flags=GFP_KERNEL|__GFP_ZERO node=0 accounted=false

Each mem_cgroup_per_node alloc 2944bytes(include hw cacheline align),
compare to 4096, it avoid waste.

Link: https://lkml.kernel.org/r/20250425031935.76411-4-link@vivo.com
Signed-off-by: Huan Yang <link@vivo.com>
Acked-by: Shakeel Butt <shakeel.butt@linux.dev>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: Francesco Valla <francesco@valla.it>
Cc: guoweikang <guoweikang.kernel@gmail.com>
Cc: Huang Shijie <shijie@os.amperecomputing.com>
Cc: KP Singh <kpsingh@kernel.org>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Muchun Song <muchun.song@linux.dev>
Cc: "Paul E . McKenney" <paulmck@kernel.org>
Cc: Petr Mladek <pmladek@suse.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Raul E Rangel <rrangel@chromium.org>
Cc: Roman Gushchin <roman.gushchin@linux.dev>
Cc: "Uladzislau Rezki (Sony)" <urezki@gmail.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

Huan Yang and committed by
Andrew Morton
1b6a58e2 97e4fc4b

+6 -1
+6 -1
mm/memcontrol.c
··· 97 97 static bool cgroup_memory_nobpf __ro_after_init; 98 98 99 99 static struct kmem_cache *memcg_cachep; 100 + static struct kmem_cache *memcg_pn_cachep; 100 101 101 102 #ifdef CONFIG_CGROUP_WRITEBACK 102 103 static DECLARE_WAIT_QUEUE_HEAD(memcg_cgwb_frn_waitq); ··· 3615 3614 { 3616 3615 struct mem_cgroup_per_node *pn; 3617 3616 3618 - pn = kzalloc_node(sizeof(*pn), GFP_KERNEL, node); 3617 + pn = kmem_cache_alloc_node(memcg_pn_cachep, GFP_KERNEL | __GFP_ZERO, 3618 + node); 3619 3619 if (!pn) 3620 3620 return false; 3621 3621 ··· 5076 5074 memcg_size = struct_size_t(struct mem_cgroup, nodeinfo, nr_node_ids); 5077 5075 memcg_cachep = kmem_cache_create("mem_cgroup", memcg_size, 0, 5078 5076 SLAB_PANIC | SLAB_HWCACHE_ALIGN, NULL); 5077 + 5078 + memcg_pn_cachep = KMEM_CACHE(mem_cgroup_per_node, 5079 + SLAB_PANIC | SLAB_HWCACHE_ALIGN); 5079 5080 5080 5081 return 0; 5081 5082 }