tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

nfc: st21nfca: Drop unneeded null check in st21nfca_tx_work()

Variable 'info' is obtained via container_of() of struct work_struct, so
it cannot be NULL. Simplify the code and solve Smatch warning:

drivers/nfc/st21nfca/dep.c:119 st21nfca_tx_work() warn: can 'info' even be NULL?

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250104142043.116045-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Krzysztof Kozlowski and committed by
Jakub Kicinski 21a8a77a 3c89a986

+8 -10
+8 -10
drivers/nfc/st21nfca/dep.c
··· 116 116 struct nfc_dev *dev; 117 117 struct sk_buff *skb; 118 118 119 - if (info) { 120 - dev = info->hdev->ndev; 121 - skb = info->dep_info.tx_pending; 119 + dev = info->hdev->ndev; 120 + skb = info->dep_info.tx_pending; 122 121 123 - device_lock(&dev->dev); 122 + device_lock(&dev->dev); 124 123 125 - nfc_hci_send_cmd_async(info->hdev, ST21NFCA_RF_READER_F_GATE, 126 - ST21NFCA_WR_XCHG_DATA, skb->data, skb->len, 127 - info->async_cb, info); 128 - device_unlock(&dev->dev); 129 - kfree_skb(skb); 130 - } 124 + nfc_hci_send_cmd_async(info->hdev, ST21NFCA_RF_READER_F_GATE, 125 + ST21NFCA_WR_XCHG_DATA, skb->data, skb->len, 126 + info->async_cb, info); 127 + device_unlock(&dev->dev); 128 + kfree_skb(skb); 131 129 } 132 130 133 131 static void st21nfca_im_send_pdu(struct st21nfca_hci_info *info,