tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

phy: rockchip-pcie: Properly disable TEST_WRITE strobe signal

pcie_conf is used to touch TEST_WRITE strobe signal. This signal should
be enabled, a little time waited, and then disabled. Current code clearly
was copy-pasted and never disables the strobe signal. Adjust the define.
While at it, remove PHY_CFG_RD_MASK which has been unused since
64cdc0360811 ("phy: rockchip-pcie: remove unused phy_rd_cfg function").

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Geraldo Nascimento <geraldogabriel@gmail.com>
Link: https://lore.kernel.org/r/d514d5d5627680caafa8b7548cbdfee4307f5440.1751322015.git.geraldogabriel@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Geraldo Nascimento and committed by
Vinod Koul 25facbab c3fe7071

+1 -2
+1 -2
drivers/phy/rockchip/phy-rockchip-pcie.c
··· 30 30 #define PHY_CFG_ADDR_SHIFT 1 31 31 #define PHY_CFG_DATA_MASK 0xf 32 32 #define PHY_CFG_ADDR_MASK 0x3f 33 - #define PHY_CFG_RD_MASK 0x3ff 34 33 #define PHY_CFG_WR_ENABLE 1 35 - #define PHY_CFG_WR_DISABLE 1 34 + #define PHY_CFG_WR_DISABLE 0 36 35 #define PHY_CFG_WR_SHIFT 0 37 36 #define PHY_CFG_WR_MASK 1 38 37 #define PHY_CFG_PLL_LOCK 0x10