tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mm/damon/tests/vaddr-kunit: handle alloc failures on damon_do_test_apply_three_regions()

damon_do_test_apply_three_regions() is assuming all dynamic memory
allocation in it will succeed. Those are indeed likely in the real use
cases since those allocations are too small to fail, but theoretically
those could fail. In the case, inappropriate memory access can happen.
Fix it by appropriately cleanup pre-allocated memory and skip the
execution of the remaining tests in the failure cases.

Link: https://lkml.kernel.org/r/20251101182021.74868-18-sj@kernel.org
Fixes: 17ccae8bb5c9 ("mm/damon: add kunit tests")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@google.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <stable@vger.kernel.org> [5.15+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

SeongJae Park and committed by
Andrew Morton 2b22d0fc 84be856c

+6
+6
mm/damon/tests/vaddr-kunit.h
··· 136 136 int i; 137 137 138 138 t = damon_new_target(); 139 + if (!t) 140 + kunit_skip(test, "target alloc fail"); 139 141 for (i = 0; i < nr_regions / 2; i++) { 140 142 r = damon_new_region(regions[i * 2], regions[i * 2 + 1]); 143 + if (!r) { 144 + damon_destroy_target(t, NULL); 145 + kunit_skip(test, "region alloc fail"); 146 + } 141 147 damon_add_region(r, t); 142 148 } 143 149