tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mm/damon/tests/core-kunit: handle alloc failures on damon_test_set_filters_default_reject()

damon_test_set_filters_default_reject() is assuming all dynamic memory
allocation in it will succeed. Those are indeed likely in the real use
cases since those allocations are too small to fail, but theoretically
those could fail. In the case, inappropriate memory access can happen.
Fix it by appropriately cleanup pre-allocated memory and skip the
execution of the remaining tests in the failure cases.

Link: https://lkml.kernel.org/r/20251101182021.74868-17-sj@kernel.org
Fixes: 094fb14913c7 ("mm/damon/tests/core-kunit: add a test for damos_set_filters_default_reject()")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@google.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <stable@vger.kernel.org> [6.16+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

SeongJae Park and committed by
Andrew Morton 84be856c d14d5671

+6
+6
mm/damon/tests/core-kunit.h
··· 659 659 KUNIT_EXPECT_EQ(test, scheme.ops_filters_default_reject, false); 660 660 661 661 target_filter = damos_new_filter(DAMOS_FILTER_TYPE_TARGET, true, true); 662 + if (!target_filter) 663 + kunit_skip(test, "filter alloc fail"); 662 664 damos_add_filter(&scheme, target_filter); 663 665 damos_set_filters_default_reject(&scheme); 664 666 /* ··· 686 684 KUNIT_EXPECT_EQ(test, scheme.ops_filters_default_reject, false); 687 685 688 686 anon_filter = damos_new_filter(DAMOS_FILTER_TYPE_ANON, true, true); 687 + if (!anon_filter) { 688 + damos_free_filter(target_filter); 689 + kunit_skip(test, "anon_filter alloc fail"); 690 + } 689 691 damos_add_filter(&scheme, anon_filter); 690 692 691 693 damos_set_filters_default_reject(&scheme);