tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/panel: ltk500hd1829: Don't call unprepare+disable at shutdown/remove

It's the responsibility of a correctly written DRM modeset driver to
call drm_atomic_helper_shutdown() at shutdown time and that should be
disabling / unpreparing the panel if needed. Panel drivers shouldn't
be calling these functions themselves.

A recent effort was made to fix as many DRM modeset drivers as
possible [1] [2] [3] and most drivers are fixed now.

Unfortunately, grepping mainline for this panel's compatible string
shows no hits, so we can't be 100% sure if the DRM modeset driver used
with this panel has been fixed. If it is found that the DRM modeset
driver hasn't been fixed then this patch could be temporarily reverted
until it is.

[1] https://lore.kernel.org/r/20230901234015.566018-1-dianders@chromium.org
[2] https://lore.kernel.org/r/20230901234202.566951-1-dianders@chromium.org
[3] https://lore.kernel.org/r/20230921192749.1542462-1-dianders@chromium.org

Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Maxime Ripard <mripard@kernel.org>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240503143327.RFT.v2.17.If3edcf846f754b425959980039372a9fd1599ecc@changeid

Douglas Anderson 3357f6f4 2b8c19b9

-17
-17
drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c
··· 662 662 return 0; 663 663 } 664 664 665 - static void ltk500hd1829_shutdown(struct mipi_dsi_device *dsi) 666 - { 667 - struct ltk500hd1829 *ctx = mipi_dsi_get_drvdata(dsi); 668 - int ret; 669 - 670 - ret = drm_panel_unprepare(&ctx->panel); 671 - if (ret < 0) 672 - dev_err(&dsi->dev, "Failed to unprepare panel: %d\n", ret); 673 - 674 - ret = drm_panel_disable(&ctx->panel); 675 - if (ret < 0) 676 - dev_err(&dsi->dev, "Failed to disable panel: %d\n", ret); 677 - } 678 - 679 665 static void ltk500hd1829_remove(struct mipi_dsi_device *dsi) 680 666 { 681 667 struct ltk500hd1829 *ctx = mipi_dsi_get_drvdata(dsi); 682 668 int ret; 683 - 684 - ltk500hd1829_shutdown(dsi); 685 669 686 670 ret = mipi_dsi_detach(dsi); 687 671 if (ret < 0) ··· 694 710 }, 695 711 .probe = ltk500hd1829_probe, 696 712 .remove = ltk500hd1829_remove, 697 - .shutdown = ltk500hd1829_shutdown, 698 713 }; 699 714 module_mipi_dsi_driver(ltk500hd1829_driver); 700 715