tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

x86/crc: drop "glue" from filenames

The use of the term "glue" in filenames is a Crypto API-ism that rarely
shows up elsewhere in lib/ or arch/*/lib/. I think adopting it there
was a mistake. The library just uses standard functions, so the amount
of code that could be considered "glue" is quite small. And while often
the C functions just wrap the assembly functions, there are also cases
like crc32c_arch() in arch/x86/lib/crc32-glue.c that blur the line by
in-lining the actual implementation into the C function. That's not
"glue code", but rather the actual code.

Therefore, let's drop "glue" from the filenames and instead use e.g.
crc32.c instead of crc32-glue.c.

Reviewed-by: "Martin K. Petersen" <martin.petersen@oracle.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Link: https://lore.kernel.org/r/20250424002038.179114-8-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>

Eric Biggers 35984c73 ee858d83

+3 -3
+3 -3
arch/x86/lib/Makefile
··· 39 39 lib-$(CONFIG_MITIGATION_RETPOLINE) += retpoline.o 40 40 41 41 obj-$(CONFIG_CRC32_ARCH) += crc32-x86.o 42 - crc32-x86-y := crc32-glue.o crc32-pclmul.o 42 + crc32-x86-y := crc32.o crc32-pclmul.o 43 43 crc32-x86-$(CONFIG_64BIT) += crc32c-3way.o 44 44 45 45 obj-$(CONFIG_CRC64_ARCH) += crc64-x86.o 46 - crc64-x86-y := crc64-glue.o crc64-pclmul.o 46 + crc64-x86-y := crc64.o crc64-pclmul.o 47 47 48 48 obj-$(CONFIG_CRC_T10DIF_ARCH) += crc-t10dif-x86.o 49 - crc-t10dif-x86-y := crc-t10dif-glue.o crc16-msb-pclmul.o 49 + crc-t10dif-x86-y := crc-t10dif.o crc16-msb-pclmul.o 50 50 51 51 obj-y += msr.o msr-reg.o msr-reg-export.o hweight.o 52 52 obj-y += iomem.o
arch/x86/lib/crc-t10dif-glue.c arch/x86/lib/crc-t10dif.c
arch/x86/lib/crc32-glue.c arch/x86/lib/crc32.c
arch/x86/lib/crc64-glue.c arch/x86/lib/crc64.c