tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

watchdog: riowd: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20230303213716.2123717-26-u.kleine-koenig@pengutronix.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>

authored by

Uwe Kleine-König and committed by
Wim Van Sebroeck 3628149f b481d57b

+2 -4
+2 -4
drivers/watchdog/riowd.c
··· 217 217 return err; 218 218 } 219 219 220 - static int riowd_remove(struct platform_device *op) 220 + static void riowd_remove(struct platform_device *op) 221 221 { 222 222 struct riowd *p = platform_get_drvdata(op); 223 223 224 224 misc_deregister(&riowd_miscdev); 225 225 of_iounmap(&op->resource[0], p->regs, 2); 226 - 227 - return 0; 228 226 } 229 227 230 228 static const struct of_device_id riowd_match[] = { ··· 239 241 .of_match_table = riowd_match, 240 242 }, 241 243 .probe = riowd_probe, 242 - .remove = riowd_remove, 244 + .remove_new = riowd_remove, 243 245 }; 244 246 245 247 module_platform_driver(riowd_driver);