Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

watchdog: renesas: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20230303213716.2123717-25-u.kleine-koenig@pengutronix.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>

authored by

Uwe Kleine-König and committed by
Wim Van Sebroeck
b481d57b 6645579b

+2 -4
+2 -4
drivers/watchdog/renesas_wdt.c
··· 292 292 return ret; 293 293 } 294 294 295 - static int rwdt_remove(struct platform_device *pdev) 295 + static void rwdt_remove(struct platform_device *pdev) 296 296 { 297 297 struct rwdt_priv *priv = platform_get_drvdata(pdev); 298 298 299 299 watchdog_unregister_device(&priv->wdev); 300 300 pm_runtime_disable(&pdev->dev); 301 - 302 - return 0; 303 301 } 304 302 305 303 static int __maybe_unused rwdt_suspend(struct device *dev) ··· 337 339 .pm = &rwdt_pm_ops, 338 340 }, 339 341 .probe = rwdt_probe, 340 - .remove = rwdt_remove, 342 + .remove_new = rwdt_remove, 341 343 }; 342 344 module_platform_driver(rwdt_driver); 343 345