Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
drm/vc4: kms: Improve logging
When debugging, finding out what muxing decisions were made and what the
actual core clock rate is is always useful, so let's add some more
messages.
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20220328153659.2382206-7-maxime@cerno.tech
+19
-1
+19
-1
drivers/gpu/drm/vc4/vc4_kms.c
+19
-1
drivers/gpu/drm/vc4/vc4_kms.c
···
439
439
* requirements.
440
440
*/
441
441
clk_set_min_rate(hvs->core_clk, new_hvs_state->core_clock_rate);
442
+
443
+
drm_dbg(dev, "Core clock actual rate: %lu Hz\n",
444
+
clk_get_rate(hvs->core_clk));
442
445
}
443
446
}
444
447
···
825
822
unsigned int matching_channels;
826
823
unsigned int channel;
827
824
825
+
drm_dbg(dev, "%s: Trying to find a channel.\n", crtc->name);
826
+
828
827
/* Nothing to do here, let's skip it */
829
-
if (old_crtc_state->enable == new_crtc_state->enable)
828
+
if (old_crtc_state->enable == new_crtc_state->enable) {
829
+
if (new_crtc_state->enable)
830
+
drm_dbg(dev, "%s: Already enabled, reusing channel %d.\n",
831
+
crtc->name, new_vc4_crtc_state->assigned_channel);
832
+
else
833
+
drm_dbg(dev, "%s: Disabled, ignoring.\n", crtc->name);
834
+
830
835
continue;
836
+
}
831
837
832
838
/* Muxing will need to be modified, mark it as such */
833
839
new_vc4_crtc_state->update_muxing = true;
···
844
832
/* If we're disabling our CRTC, we put back our channel */
845
833
if (!new_crtc_state->enable) {
846
834
channel = old_vc4_crtc_state->assigned_channel;
835
+
836
+
drm_dbg(dev, "%s: Disabling, Freeing channel %d\n",
837
+
crtc->name, channel);
838
+
847
839
hvs_new_state->fifo_state[channel].in_use = false;
848
840
new_vc4_crtc_state->assigned_channel = VC4_HVS_CHANNEL_DISABLED;
849
841
continue;
···
882
866
return -EINVAL;
883
867
884
868
channel = ffs(matching_channels) - 1;
869
+
870
+
drm_dbg(dev, "Assigned HVS channel %d to CRTC %s\n", channel, crtc->name);
885
871
new_vc4_crtc_state->assigned_channel = channel;
886
872
unassigned_channels &= ~BIT(channel);
887
873
hvs_new_state->fifo_state[channel].in_use = true;