tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

spi: pic32-sqi: fix controller deregistration

Make sure to deregister the controller before releasing underlying
resources like DMA during driver unbind.

Fixes: 3270ac230f66 ("spi: pic32-sqi: add SPI driver for PIC32 SQI controller.")
Cc: stable@vger.kernel.org # 4.7
Cc: Purna Chandra Mandal <purna.mandal@microchip.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20260410081757.503099-8-johan@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Johan Hovold and committed by
Mark Brown 420df79d 6b627bfe

+7 -1
+7 -1
drivers/spi/spi-pic32-sqi.c
··· 642 642 host->prepare_transfer_hardware = pic32_sqi_prepare_hardware; 643 643 host->unprepare_transfer_hardware = pic32_sqi_unprepare_hardware; 644 644 645 - ret = devm_spi_register_controller(&pdev->dev, host); 645 + ret = spi_register_controller(host); 646 646 if (ret) { 647 647 dev_err(&host->dev, "failed registering spi host\n"); 648 648 free_irq(sqi->irq, sqi); ··· 665 665 { 666 666 struct pic32_sqi *sqi = platform_get_drvdata(pdev); 667 667 668 + spi_controller_get(sqi->host); 669 + 670 + spi_unregister_controller(sqi->host); 671 + 668 672 /* release resources */ 669 673 free_irq(sqi->irq, sqi); 670 674 ring_desc_ring_free(sqi); 675 + 676 + spi_controller_put(sqi->host); 671 677 } 672 678 673 679 static const struct of_device_id pic32_sqi_of_ids[] = {