Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

phy: rockchip-samsung-dcphy: Discard pm_runtime_put() return value

Passing pm_runtime_put() return value to the callers is not particularly
useful.

Returning an error code from pm_runtime_put() merely means that it has
not queued up a work item to check whether or not the device can be
suspended and there are many perfectly valid situations in which that
can happen, like after writing "on" to the devices' runtime PM "control"
attribute in sysfs for one example. It also happens when the kernel is
configured with CONFIG_PM unset.

Accordingly, update samsung_mipi_dcphy_exit() to simply discard the
return value of pm_runtime_put() and always return success to the
caller.

This will facilitate a planned change of the pm_runtime_put() return
type to void in the future.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/2281919.Icojqenx9y@rafael.j.wysocki
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Rafael J. Wysocki and committed by
Vinod Koul
455bf7d9 8bb108e4

+3 -1
+3 -1
drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c
··· 1508 1508 { 1509 1509 struct samsung_mipi_dcphy *samsung = phy_get_drvdata(phy); 1510 1510 1511 - return pm_runtime_put(samsung->dev); 1511 + pm_runtime_put(samsung->dev); 1512 + 1513 + return 0; 1512 1514 } 1513 1515 1514 1516 static const struct phy_ops samsung_mipi_dcphy_ops = {